From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct Date: Mon, 01 Jul 2013 08:48:50 +0200 Message-ID: <51D12652.3090804@gmail.com> References: <1372626555-29479-1-git-send-email-zonque@gmail.com> <20130701013324.GA10755@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:53448 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734Ab3GAGs2 (ORCPT ); Mon, 1 Jul 2013 02:48:28 -0400 Received: by mail-bk0-f46.google.com with SMTP id na10so1495652bkb.19 for ; Sun, 30 Jun 2013 23:48:26 -0700 (PDT) In-Reply-To: <20130701013324.GA10755@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, broonie@kernel.org, grant.likely@linaro.org, agust@denx.de, imre.deak@nokia.com, chf@fritzc.com Hi Dmitry, On 01.07.2013 03:33, Dmitry Torokhov wrote: > On Sun, Jun 30, 2013 at 11:09:14PM +0200, Daniel Mack wrote: >> + >> + if (!pdata->model) >> + pdata->model = 7846; >> + >> + if (!pdata->vref_delay_usecs) >> + pdata->vref_delay_usecs = 100; >> + >> + if (!pdata->x_plate_ohms) >> + pdata->x_plate_ohms = 400; >> + >> + if (!pdata->pressure_max) >> + pdata->pressure_max = ~0; > > We should not be changing the platform data as the device does not own > it and it may well be declared as a constant structure. We don't change the platform data that is passed in via the driver core. We keep a copy of it in our private strucz (that's what the subject says) and in case of DT, we modify that copy. The passed pdata is left untouched. Thanks, Daniel