From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup Date: Thu, 11 Jul 2013 17:08:30 +0400 Message-ID: <51DEAE4E.90204@cogentembedded.com> References: <1373533573-12272-1-git-send-email-ming.lei@canonical.com> <1373533573-12272-46-git-send-email-ming.lei@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373533573-12272-46-git-send-email-ming.lei@canonical.com> Sender: linux-media-owner@vger.kernel.org To: Ming Lei Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Oliver Neukum , Alan Stern , linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai List-Id: linux-input@vger.kernel.org On 11-07-2013 13:06, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). Changelog doesn't match the patch. > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org > Signed-off-by: Ming Lei > --- > sound/usb/usx2y/usbusx2yaudio.c | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c > index 4967fe9..e2ee893 100644 > --- a/sound/usb/usx2y/usbusx2yaudio.c > +++ b/sound/usb/usx2y/usbusx2yaudio.c > @@ -273,7 +273,11 @@ static void usX2Y_clients_stop(struct usX2Ydev *usX2Y) > struct snd_usX2Y_substream *subs = usX2Y->subs[s]; > if (subs) { > if (atomic_read(&subs->state) >= state_PRERUNNING) { > + unsigned long flags; > + > + local_irq_save(flags); > snd_pcm_stop(subs->pcm_substream, SNDRV_PCM_STATE_XRUN); > + local_irq_restore(flags); > } WBR, Sergei