From: Benjamin Tissoires <benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Gustavo Padovan <gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] Bluetooth: hidp: remove wrong send_report at init
Date: Fri, 12 Jul 2013 14:55:23 +0200 [thread overview]
Message-ID: <51DFFCBB.3090709@redhat.com> (raw)
In-Reply-To: <20130712100923.GA2065@joana>
On 07/12/2013 12:09 PM, Gustavo Padovan wrote:
> Hi Benjamin,
>
> * Benjamin Tissoires <benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> [2013-07-11 15:41:30 +0200]:
>
>> The USB hid implementation does retrieve the reports during the start.
>> However, this implementation does not call the HID command GET_REPORT
>> (which would fetch the current status of each report), but use the
>> DATA command, which is an Output Report (so transmitting data from the
>> host to the device).
>> The Wiimote controller is already guarded against this problem in the
>> protocol, but it is not conformant to the specification to set all the
>> reports to 0 on start.
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> net/bluetooth/hidp/core.c | 14 --------------
>> 1 file changed, 14 deletions(-)
>
> Both patches have been applied to bluetooth-next. Thanks.
>
> Gustavo
>
Thanks Gustavo!
Cheers,
Benjamin
prev parent reply other threads:[~2013-07-12 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:41 [PATCH 0/2] Bluetooth: hidp: cleanup HID init and re-enable hidinput_input_event callback Benjamin Tissoires
[not found] ` <1373550090-30379-1-git-send-email-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-11 13:41 ` [PATCH 1/2] Bluetooth: hidp: implement " Benjamin Tissoires
2013-07-11 14:02 ` David Herrmann
2013-07-11 14:10 ` Benjamin Tissoires
2013-07-11 16:07 ` David Herrmann
[not found] ` <1373550090-30379-2-git-send-email-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-11 22:50 ` Jiri Kosina
2013-07-11 13:41 ` [PATCH 2/2] Bluetooth: hidp: remove wrong send_report at init Benjamin Tissoires
2013-07-11 13:51 ` David Herrmann
2013-07-11 22:51 ` Jiri Kosina
[not found] ` <1373550090-30379-3-git-send-email-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-12 10:09 ` Gustavo Padovan
2013-07-12 12:55 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DFFCBB.3090709@redhat.com \
--to=benjamin.tissoires-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).