From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jiri Kosina <jikos@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices
Date: Sun, 11 Jun 2023 21:53:51 -0700 [thread overview]
Message-ID: <51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2306091742090.5716@cbobk.fhfr.pm>
On Fri, 2023-06-09 at 17:43 +0200, Jiri Kosina wrote:
> On Sun, 28 May 2023, Daniel Thompson wrote:
>
> > The Lenovo Yoga C630 has a combined keyboard and accelerometer that
> > interfaces via i2c-hid. Currently this laptop either has a working
> > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working
> > accelerometer.
> > only works on kernels. Put another way, most distro kernels enable
> > CONFIG_HID_SENSOR_HUB and therefore cannot work on this device
> > since the
> > keyboard doesn't work!
> >
> > Fix this by providing a richer connect mask during the probe. With
> > this
> > change both keyboard and screen orientation sensors work correctly.
> >
> > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Srinivas, are you aware of any multi-function device that this patch
> might
> break?
I tried two systems, one with ISH and another with external hub.
Didn't break anything.
I don't have 5+ years old systems, to confirm if it will break
something on older systems with external hub.
Thanks,
Srinivas
>
> Thanks,
>
next prev parent reply other threads:[~2023-06-12 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 9:24 [PATCH] HID: sensor-hub: Allow multi-function sensor devices Daniel Thompson
2023-06-09 15:43 ` Jiri Kosina
2023-06-12 4:53 ` srinivas pandruvada [this message]
2023-06-12 7:39 ` Jiri Kosina
2023-06-12 13:34 ` srinivas pandruvada
2023-08-14 9:13 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51dfdee66713e470d9a925ac5a8f8ae1da644462.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=andersson@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=daniel.thompson@linaro.org \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).