From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH 1/4] hid-sensor-hub: fix style of comments
Date: Mon, 19 Aug 2013 08:26:39 -0700 [thread overview]
Message-ID: <5212392F.8090204@linux.intel.com> (raw)
In-Reply-To: <1376902117.403.151.camel@smile>
On 08/19/2013 01:48 AM, Andy Shevchenko wrote:
> On Wed, 2013-08-14 at 11:07 +0300, Andy Shevchenko wrote:
>> This patch fixes the style of the comments to be like following
>> /* The commentary */
>>
>> There is no functional change.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Jiri, Srinivas, any comments on this?
Agreed.
>> ---
>> drivers/hid/hid-sensor-hub.c | 2 +-
>> include/linux/hid-sensor-hub.h | 2 +-
>> include/linux/hid-sensor-ids.h | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
>> index ca749810..ffc80cf 100644
>> --- a/drivers/hid/hid-sensor-hub.c
>> +++ b/drivers/hid/hid-sensor-hub.c
>> @@ -416,7 +416,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
>> return 1;
>>
>> ptr = raw_data;
>> - ptr++; /*Skip report id*/
>> + ptr++; /* Skip report id */
>>
>> spin_lock_irqsave(&pdata->lock, flags);
>>
>> diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h
>> index ecefb73..32ba451 100644
>> --- a/include/linux/hid-sensor-hub.h
>> +++ b/include/linux/hid-sensor-hub.h
>> @@ -172,7 +172,7 @@ struct hid_sensor_common {
>> struct hid_sensor_hub_attribute_info sensitivity;
>> };
>>
>> -/*Convert from hid unit expo to regular exponent*/
>> +/* Convert from hid unit expo to regular exponent */
>> static inline int hid_sensor_convert_exponent(int unit_expo)
>> {
>> if (unit_expo < 0x08)
>> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
>> index 6f24446..4f945d3 100644
>> --- a/include/linux/hid-sensor-ids.h
>> +++ b/include/linux/hid-sensor-ids.h
>> @@ -37,7 +37,7 @@
>> #define HID_USAGE_SENSOR_ANGL_VELOCITY_Y_AXIS 0x200458
>> #define HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS 0x200459
>>
>> -/*ORIENTATION: Compass 3D: (200083) */
>> +/* ORIENTATION: Compass 3D: (200083) */
>> #define HID_USAGE_SENSOR_COMPASS_3D 0x200083
>> #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471
>> #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472
Thanks,
Srinivas
next prev parent reply other threads:[~2013-08-19 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 8:07 [PATCH 1/4] hid-sensor-hub: fix style of comments Andy Shevchenko
2013-08-14 8:07 ` [PATCH 2/4] hid-sensor-hub: fix indentation accross the code Andy Shevchenko
2013-08-19 15:28 ` Srinivas Pandruvada
2013-08-29 14:53 ` Andy Shevchenko
2013-09-04 10:21 ` Jiri Kosina
2013-08-14 8:07 ` [PATCH 3/4] hid-sensor-hub: move to devm_kzalloc Andy Shevchenko
2013-08-19 15:31 ` Srinivas Pandruvada
2013-08-14 8:07 ` [PATCH 4/4] hid-sensor-hub: change kmalloc + memcpy by kmemdup Andy Shevchenko
2013-08-19 15:32 ` Srinivas Pandruvada
2013-08-19 8:48 ` [PATCH 1/4] hid-sensor-hub: fix style of comments Andy Shevchenko
2013-08-19 15:26 ` Srinivas Pandruvada [this message]
2013-08-26 11:46 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212392F.8090204@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).