* [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer()
@ 2013-08-26 6:00 Wei Yongjun
2013-08-26 6:28 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-08-26 6:00 UTC (permalink / raw)
To: javier, dmitry.torokhov; +Cc: yongjun_wei, linux-input
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Remove useless NULL test from cyttsp4_watchdog_timer().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
v1 -> v2: remove NULL test instead.
(was: Input: cyttsp4 - fix potential NULL pointer dereference in cyttsp4_watchdog_timer())
---
drivers/input/touchscreen/cyttsp4_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c
index edcf799..22719d0 100644
--- a/drivers/input/touchscreen/cyttsp4_core.c
+++ b/drivers/input/touchscreen/cyttsp4_core.c
@@ -1246,9 +1246,6 @@ static void cyttsp4_watchdog_timer(unsigned long handle)
dev_vdbg(cd->dev, "%s: Watchdog timer triggered\n", __func__);
- if (!cd)
- return;
-
if (!work_pending(&cd->watchdog_work))
schedule_work(&cd->watchdog_work);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer()
2013-08-26 6:00 [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer() Wei Yongjun
@ 2013-08-26 6:28 ` Ferruh Yigit
2013-08-26 7:16 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2013-08-26 6:28 UTC (permalink / raw)
To: Wei Yongjun; +Cc: javier, dmitry.torokhov, yongjun_wei, linux-input
On 08/26/2013 09:00 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove useless NULL test from cyttsp4_watchdog_timer().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> v1 -> v2: remove NULL test instead.
> (was: Input: cyttsp4 - fix potential NULL pointer dereference in cyttsp4_watchdog_timer())
> ---
> drivers/input/touchscreen/cyttsp4_core.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Ferruh Yigit <fery@cypress.com>
--
ferruh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer()
2013-08-26 6:28 ` Ferruh Yigit
@ 2013-08-26 7:16 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2013-08-26 7:16 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Wei Yongjun, javier, yongjun_wei, linux-input
On Mon, Aug 26, 2013 at 09:28:28AM +0300, Ferruh Yigit wrote:
> On 08/26/2013 09:00 AM, Wei Yongjun wrote:
> >From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> >Remove useless NULL test from cyttsp4_watchdog_timer().
> >
> >Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >---
> >v1 -> v2: remove NULL test instead.
> > (was: Input: cyttsp4 - fix potential NULL pointer dereference in cyttsp4_watchdog_timer())
> >---
> > drivers/input/touchscreen/cyttsp4_core.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Acked-by: Ferruh Yigit <fery@cypress.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-26 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 6:00 [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer() Wei Yongjun
2013-08-26 6:28 ` Ferruh Yigit
2013-08-26 7:16 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).