From: Rafi Rubin <rafi@seas.upenn.edu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH 10/14] HID: ntrig: validate feature report details
Date: Thu, 29 Aug 2013 11:12:03 -0400 [thread overview]
Message-ID: <521F64C3.8000201@seas.upenn.edu> (raw)
In-Reply-To: <alpine.LNX.2.00.1308282221210.22181@pobox.suse.cz>
Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
Thanks Kees,
Rafi
On 08/28/13 16:31, Jiri Kosina wrote:
> From: Kees Cook <keescook@chromium.org>
>
> A HID device could send a malicious feature report that would cause the
> ntrig HID driver to trigger a NULL dereference during initialization:
>
> [57383.031190] usb 3-1: New USB device found, idVendor=1b96, idProduct=0001
> ...
> [57383.315193] BUG: unable to handle kernel NULL pointer dereference at 0000000000000030
> [57383.315308] IP: [<ffffffffa08102de>] ntrig_probe+0x25e/0x420 [hid_ntrig]
>
> CVE-2013-2896
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: stable@kernel.org
> ---
> drivers/hid/hid-ntrig.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
> index ef95102..5482156 100644
> --- a/drivers/hid/hid-ntrig.c
> +++ b/drivers/hid/hid-ntrig.c
> @@ -115,7 +115,8 @@ static inline int ntrig_get_mode(struct hid_device *hdev)
> struct hid_report *report = hdev->report_enum[HID_FEATURE_REPORT].
> report_id_hash[0x0d];
>
> - if (!report)
> + if (!report || report->maxfield < 1 ||
> + report->field[0]->report_count < 1)
> return -EINVAL;
>
> hid_hw_request(hdev, report, HID_REQ_GET_REPORT);
>
next prev parent reply other threads:[~2013-08-29 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 20:31 [PATCH 10/14] HID: ntrig: validate feature report details Jiri Kosina
2013-08-29 15:12 ` Rafi Rubin [this message]
2013-09-04 10:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F64C3.8000201@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).