* [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put
@ 2013-08-31 6:45 Libo Chen
2013-09-01 17:01 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Libo Chen @ 2013-08-31 6:45 UTC (permalink / raw)
To: dmitry.torokhov
Cc: peter.ujfalusi, Bill Pemberton, broonie, linux-input, LKML
decrease node device_node refcount after task completion
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/input/misc/twl4030-vibra.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
index 68a5f33..b8d1526 100644
--- a/drivers/input/misc/twl4030-vibra.c
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
if (pdata && pdata->coexist)
return true;
- if (of_find_node_by_name(node, "codec"))
+ if (of_find_node_by_name(node, "codec")) {
+ of_node_put(node);
return true;
+ }
return false;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put
2013-08-31 6:45 [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put Libo Chen
@ 2013-09-01 17:01 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2013-09-01 17:01 UTC (permalink / raw)
To: Libo Chen; +Cc: dmitry.torokhov, Bill Pemberton, broonie, linux-input, LKML
On 08/31/2013 09:45 AM, Libo Chen wrote:
>
> decrease node device_node refcount after task completion
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/input/misc/twl4030-vibra.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
> index 68a5f33..b8d1526 100644
> --- a/drivers/input/misc/twl4030-vibra.c
> +++ b/drivers/input/misc/twl4030-vibra.c
> @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
> if (pdata && pdata->coexist)
> return true;
>
> - if (of_find_node_by_name(node, "codec"))
> + if (of_find_node_by_name(node, "codec")) {
> + of_node_put(node);
> return true;
> + }
>
> return false;
> }
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-01 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-31 6:45 [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put Libo Chen
2013-09-01 17:01 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).