From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Subject: Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event Date: Wed, 11 Sep 2013 10:26:10 +1000 Message-ID: <522FB8A2.7070608@gmail.com> References: <1378855973-11595-1-git-send-email-rmallon@gmail.com> <1378855973-11595-2-git-send-email-rmallon@gmail.com> <20130911001235.GA5840@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:35061 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab3IKA0O (ORCPT ); Tue, 10 Sep 2013 20:26:14 -0400 In-Reply-To: <20130911001235.GA5840@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: rydberg@euromail.se, carl@ok-labs.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On 11/09/13 10:12, Dmitry Torokhov wrote: > Hi Ryan, > > On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote: >> Call input_inject_event rather than input_event in uinput_inject_event. This >> mirrors the behaviour of evdev_write. input_inject_event will ignore the >> injected event if the uinput input device has been grabbed for exclusive >> access by a handler other than uinput. > > uinput is not an input handler but input driver and therefore should > continue using input_event(). Ah, I wasn't sure about this, which is why I broke it out into a separate patch. Sorry for the noise. ~Ryan