From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH v3 03/10] HID: sony: validate HID output report details Date: Thu, 12 Sep 2013 16:11:47 +0200 Message-ID: <5231CBA3.3070405@redhat.com> References: <1378929419-6269-1-git-send-email-benjamin.tissoires@redhat.com> <1378929419-6269-4-git-send-email-benjamin.tissoires@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130Ab3ILOMB (ORCPT ); Thu, 12 Sep 2013 10:12:01 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Josh Boyer Cc: Benjamin Tissoires , Kees Cook , Henrik Rydberg , Jiri Kosina , linux-input@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" On 12/09/13 14:39, Josh Boyer wrote: > On Wed, Sep 11, 2013 at 3:56 PM, Benjamin Tissoires > wrote: >> From: Kees Cook >> >> This driver must validate the availability of the HID output report and >> its size before it can write LED states via buzz_set_leds(). This stops >> a heap overflow that is possible if a device provides a malicious HID >> output report: >> >> [ 108.171280] usb 1-1: New USB device found, idVendor=054c, idProduct=0002 >> ... >> [ 117.507877] BUG kmalloc-192 (Not tainted): Redzone overwritten >> >> CVE-2013-2890 >> >> Signed-off-by: Kees Cook >> Cc: stable@vger.kernel.org >> Reviewed-by: Benjamin Tissoires > > As far as I know, this should be Cc: stable@vger.kernel.org #3.11, correct? > Yep, for this one, only 3.11 is impacted. Thanks Josh. And sorry for being to lazy to have added the proper tags :( Cheers, Benjamin