From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Felipe Balbi <balbi@ti.com>
Cc: dmitry.torokhov@gmail.com, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding
Date: Tue, 22 Oct 2013 10:42:00 +0200 [thread overview]
Message-ID: <52663A58.9070706@linutronix.de> (raw)
In-Reply-To: <1382386404-6659-2-git-send-email-balbi@ti.com>
On 10/21/2013 10:13 PM, Felipe Balbi wrote:
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index e1c5300..b61df9d 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev,
> if (err < 0)
> return err;
>
> - err = of_property_read_u32(node, "ti,coordiante-readouts",
> + /*
> + * try with new binding first. If it fails, still try with
> + * bogus, miss-spelled version.
> + */
> + err = of_property_read_u32(node, "ti,coordinate-readouts",
> &ts_dev->coordinate_readouts);
> if (err < 0)
> + err = of_property_read_u32(node, "ti,coordiante-readouts",
> + &ts_dev->coordinate_readouts);
> + if (err < 0)
> return err;
Thanks, very good. Do we keep this fallback for ever or just for a year
or two?
>
> return of_property_read_u32_array(node, "ti,wire-config",
Sebastian
next prev parent reply other threads:[~2013-10-22 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 20:13 [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Felipe Balbi
2013-10-21 20:13 ` [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding Felipe Balbi
2013-10-22 8:42 ` Sebastian Andrzej Siewior [this message]
2013-10-22 12:02 ` Felipe Balbi
2013-11-14 11:19 ` Mark Rutland
2013-11-14 15:54 ` Felipe Balbi
2013-11-15 15:55 ` Mark Rutland
2013-11-15 17:53 ` Felipe Balbi
2013-11-18 11:40 ` Mark Rutland
2013-11-18 15:29 ` [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling Felipe Balbi
2013-11-18 15:35 ` Mark Rutland
2014-06-14 0:23 ` Felipe Balbi
2014-06-15 7:16 ` Dmitry Torokhov
2014-06-15 15:55 ` Felipe Balbi
2013-10-21 20:13 ` [PATCH 2/2] arm: dts: am335x sk: add touchscreen support Felipe Balbi
[not found] ` <1382386404-6659-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-11-11 7:59 ` [PATCH 0/2] arm: am335x: am335x evm sk: add touchscreen DT node Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52663A58.9070706@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).