From: "Nuno Sá" <noname.nuno@gmail.com>
To: Denis Arefev <arefev@swemel.ru>,
Michael Hennerich <michael.hennerich@analog.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, stable@vger.kernel.org
Subject: Re: [PATCH] Input: adp5588-keys - Added checking of key and key_val variables
Date: Mon, 30 Sep 2024 11:33:20 +0200 [thread overview]
Message-ID: <526e885abc278a2d369de82d80ebc21d56c7f7ba.camel@gmail.com> (raw)
In-Reply-To: <20240930083649.4703-1-arefev@swemel.ru>
On Mon, 2024-09-30 at 11:36 +0300, Denis Arefev wrote:
> If the adp5588_read function returns 0, then there will be an
> overflow of the kpad->keycode buffer.
>
> If the adp5588_read function returns a negative value, then the
> logic is broken - the wrong value is used as an index of
> the kpad->keycode array.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Cc: stable@vger.kernel.org # v5.10+
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
Hi Denis,
Thanks for the patch. However, I'm working on a more complete rework of this as
suggested in [1]. I should be sending patches for it today or tomorrow.
[1]: https://lore.kernel.org/linux-input/Zu0vq0ogr2HzXWv7@google.com/
- Nuno Sá
next prev parent reply other threads:[~2024-09-30 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 8:36 [PATCH] Input: adp5588-keys - Added checking of key and key_val variables Denis Arefev
2024-09-30 9:33 ` Nuno Sá [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-20 9:23 Denis Arefev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526e885abc278a2d369de82d80ebc21d56c7f7ba.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=arefev@swemel.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=michael.hennerich@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).