Re: [PATCH 00/19] Enable various Renesas drivers on all ARM platforms

From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Simon Horman <horms@verge.net.au>,
	Mark Brown <broonie@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-fbdev@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Vinod Koul <vinod.koul@intel.com>, Joerg Roedel <joro@8bytes.org>,
	linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
	Zhang Rui <rui.zhang@intel.com>, Chris Ball <cjb@laptop.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
	Samuel Ortiz <samuel@sortiz.org>,
	linux-pm@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
	linux-arm-kernel@lists.infradead.org, Sergei
Subject: Re: [PATCH 00/19] Enable various Renesas drivers on all ARM platforms
Date: Wed, 30 Oct 2013 12:59:08 +0200	[thread overview]
Message-ID: <5270E67C.1030307@ti.com> (raw)
In-Reply-To: <20131030000501.GE21262@verge.net.au>

[-- Attachment #1.1: Type: text/plain, Size: 1640 bytes --]

On 2013-10-30 02:05, Simon Horman wrote:
> On Tue, Oct 29, 2013 at 10:58:34AM -0700, Mark Brown wrote:
>> On Tue, Oct 29, 2013 at 06:29:59PM +0100, Laurent Pinchart wrote:
>>> On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
>>>> On Tue, Oct 29, 2013 at 06:05:53PM +0100, Laurent Pinchart wrote:
>>>>> The first one is that I can't compile-test all those drivers on all
>>>>> architectures. The spi-sh-msiof driver, for instance, uses
>>>>> io(read|write)(16|
>>
>>>> Which architectures are these and is there not a symbol we can depend on
>>>> for them?
>>
>>> arch/cris for instance. We can use readl/writel instead (maybe it would be 
>>> time to rationalize and document the I/O accessors across all architectures, 
>>> but that's another topic).
>>
>> It'd certainly be sensible, or adding a config option to depend on if
>> you rely on these functions.
>>
>>> My point is that there might be other issues that I won't be able to easily 
>>> catch. This would break compilation for everybody for no reason, as the 
>>> drivers are useless on non-SuperH, non-ARM platforms. That's why I believe 
>>> COMPILE_TEST would be a better option as a first step.
>>
>> Yes, it would - please do that.  Note that it won't stop anyone running
>> into build issues on other architectures though, it's just about
>> stopping Kconfig noise.
> 
> FWIW, I am happy with using COMPILE_TEST for this series.

I'd also go for COMPILE_TEST. I once enabled omapdss and omapfb to be
compilable without any extra dependencies, and Linus wasn't fond of
getting asked if he wants to compile omapfb or not...

 Tomi

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/