From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH] HID: i2c-hid: disable interrupt on suspend Date: Mon, 25 Nov 2013 10:41:57 -0500 Message-ID: <52936FC5.3060905@redhat.com> References: <1384342458-5551-1-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384342458-5551-1-git-send-email-mika.westerberg@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Mika Westerberg , Jiri Kosina Cc: Jean Delvare , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Blin List-Id: linux-input@vger.kernel.org On 13/11/13 06:34, Mika Westerberg wrote: > When an I2C HID device is powered of during system sleep, as a result of > removing its power resources (by the ACPI core) the interrupt line might go > low as well. This results inadvertent interrupt and wakes the system from > sleep immediately. > > To prevent this we disable the device interrupt in the drivers suspend > method and enable it on resume. The device can still wake the system up if > it is wake capable (this also means that not all of its power will be > removed to keep the interrupt line high). > > Reported-by: Jerome Blin > Signed-off-by: Mika Westerberg > --- Jiri, just FYI, I still do not have any final consumer ready i2c-hid hardware. So I can not test/debug anything related to the suspend-resume. If Mika tested it properly (which I expect), you may consider pulling this one. Cheers, Benjamin