From: Zawullon <zawullon@gmail.com>
To: jkosina@suse.cz
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] hid: add NOGET quirk and device id for Logitech Dual Action gamepads support
Date: Sat, 30 Nov 2013 13:51:28 +0400 [thread overview]
Message-ID: <5299B520.9060200@gmail.com> (raw)
Issue description: I have two Logitech Dual Action gamepads, both have
same Vendor/Device id pair. Newest gamepad (A) can switch between old mode (HID)
and XBox gamepad emulation mode. Old gamepad (B) can only work in HID mode.
In HID mode gamepad A sends many EPIPE errors during initialization and was
disconnected immediately after connect to usb port. It works fine in Win and
Mac. After adding NOGET quirk in driver, it was working properly.
Gamepad B works fine before and after changes. I tested both gamepads
with 3.8.0 and 3.11.6 kernels with modified driver. Follow patch can apply
for current git kernel version. I can send pcap log from usb bus with both
gamepads or any other additional information if it is needed
diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-ids.h linux-my/drivers/hid/hid-ids.h
--- linux-git/drivers/hid/hid-ids.h 2013-11-30 13:29:27.937351968 +0400
+++ linux-my/drivers/hid/hid-ids.h 2013-11-30 13:46:05.201378674 +0400
@@ -552,6 +552,7 @@
#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD 0xc20a
#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD 0xc211
#define USB_DEVICE_ID_LOGITECH_EXTREME_3D 0xc215
+#define USB_DEVICE_ID_LOGITECH_DUAL_ACTION 0xc216
#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2 0xc218
#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2_2 0xc219
#define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283
diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-lg.c linux-my/drivers/hid/hid-lg.c
--- linux-git/drivers/hid/hid-lg.c 2013-11-30 13:29:27.937351968 +0400
+++ linux-my/drivers/hid/hid-lg.c 2013-11-30 13:46:05.201378674 +0400
@@ -758,6 +758,8 @@ static const struct hid_device_id lg_dev
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D),
.driver_data = LG_NOGET },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION),
+ .driver_data = LG_NOGET },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL),
.driver_data = LG_NOGET | LG_FF4 },
next reply other threads:[~2013-11-30 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 9:51 Zawullon [this message]
2013-12-02 14:13 ` [PATCH] hid: add NOGET quirk and device id for Logitech Dual Action gamepads support Jiri Kosina
2013-12-02 17:57 ` Zawullon
2013-12-02 21:51 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5299B520.9060200@gmail.com \
--to=zawullon@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).