From: Shuah Khan <shuah.kh@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Manuel Krause <manuelkrause@netscape.net>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org,
linux-serial <linux-serial@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>,
Shuah Khan <shuah.kh@samsung.com>
Subject: Re: 3.12.x looses serial mouse over hibernate + resume
Date: Mon, 02 Dec 2013 12:30:57 -0700 [thread overview]
Message-ID: <529CDFF1.2080807@samsung.com> (raw)
In-Reply-To: <20131202190824.GB5245@core.coreip.homeip.net>
On 12/02/2013 12:08 PM, Dmitry Torokhov wrote:
> On Mon, Dec 02, 2013 at 11:44:56AM -0700, Shuah Khan wrote:
>>>
>>
>> I am glad the problem is fixed. But I am puzzled. pnp_bus_resume()
>> didn't handle restore prior to this change. state doesn't get passed
>> in to legacy resume routines. I had to add freeze to handle
>> PMSG_FREEZE case, sounds like restore is needed as well, however I
>> don't see where how restore is handled prior to this change.
>
> Take a look at drivers/base/platform.c::platform_pm_restore()
>
> Thanks.
>
Yes I see it now. Before the conversion, platform_legacy_resume() path
is taken since pnp didn't have pm.
if (drv->pm) {
if (drv->pm->restore)
ret = drv->pm->restore(dev);
} else {
ret = platform_legacy_resume(dev);
}
Thanks for fixing the problem.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
next prev parent reply other threads:[~2013-12-02 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52951E69.7090602@netscape.net>
2013-12-01 15:43 ` 3.12.x looses serial mouse over hibernate + resume Peter Hurley
2013-12-02 16:08 ` Manuel Krause
2013-12-02 16:38 ` Dmitry Torokhov
2013-12-02 16:45 ` Dmitry Torokhov
2013-12-02 18:35 ` Manuel Krause
2013-12-02 18:44 ` Shuah Khan
2013-12-02 19:08 ` Dmitry Torokhov
2013-12-02 19:30 ` Shuah Khan [this message]
2013-12-02 19:07 ` Dmitry Torokhov
2013-12-02 20:40 ` Manuel Krause
2013-12-04 17:16 ` Dmitry Torokhov
2013-12-04 20:33 ` Manuel Krause
2013-12-05 0:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529CDFF1.2080807@samsung.com \
--to=shuah.kh@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuelkrause@netscape.net \
--cc=peter@hurleysoftware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).