From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>,
Peter Hutterer <peter.hutterer@redhat.com>,
Duson Lin <dusonlin@emc.com.tw>
Subject: Re: [PATCH 1/2] elantech: Properly differentiate between clickpads and normal touchpads
Date: Tue, 10 Dec 2013 09:37:08 +0100 [thread overview]
Message-ID: <52A6D2B4.8060104@redhat.com> (raw)
In-Reply-To: <20131210061256.GA12524@core.coreip.homeip.net>
Hi,
On 12/10/2013 07:12 AM, Dmitry Torokhov wrote:
<snip>
>>>> Small question here: if the touchpad is a clickpad, should'nt we also
>>>> remove the BTN_RIGHT bit too?
>>>
>>>
>>> We could, but I don't see much value in that, and it would also require
>>> if statements in the sync methods to ensure that we don't tree to send
>>> a button event for a button we don't advertise.
>>
>> We don't need this test in the sync method. The test is already
>> implemented in input_event. So now, it's just a matter of taste
>> regarding upper layers. Peter, any thoughts on this?
>
> We should not advertise events that device does not generate. This
> should help userspace to decide if emulation is needed or not. Input
> core will drop events that are not set up as valid for device, so if we
> clear BTN_RIGHT there it should all work.
Ok, v2 adding the clearing of the BTN_RIGHT bit is on its way.
Regards,
Hans
next prev parent reply other threads:[~2013-12-10 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 14:32 [PATCH 1/2] elantech: Properly differentiate between clickpads and normal touchpads Hans de Goede
2013-12-09 14:32 ` [PATCH 2/2] elantech: Add support for IC-body version 8 Hans de Goede
2013-12-09 17:50 ` Benjamin Tissoires
2013-12-09 18:02 ` [PATCH 1/2] elantech: Properly differentiate between clickpads and normal touchpads Benjamin Tissoires
2013-12-09 19:14 ` Hans de Goede
2013-12-09 19:21 ` Benjamin Tissoires
2013-12-10 6:12 ` Dmitry Torokhov
2013-12-10 8:35 ` duson
2013-12-10 8:45 ` Hans de Goede
2013-12-10 9:29 ` duson
2013-12-10 8:37 ` Hans de Goede [this message]
2013-12-10 9:58 ` Peter Hutterer
2013-12-10 5:15 ` duson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6D2B4.8060104@redhat.com \
--to=hdegoede@redhat.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dusonlin@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).