From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Heiny Subject: Re: [PATCH V2] input synaptics-rmi4: Reorder declarations in rmi_bus.c Date: Tue, 10 Dec 2013 09:41:13 -0800 Message-ID: <52A75239.5010001@synaptics.com> References: <1386289756-12429-1-git-send-email-cheiny@synaptics.com> <52A624A2.5000405@redhat.com> <20131210063914.GD12524@core.coreip.homeip.net> <20131210064624.GE12524@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from us-mx2.synaptics.com ([192.147.44.131]:43355 "EHLO us-mx2.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309Ab3LJRlO (ORCPT ); Tue, 10 Dec 2013 12:41:14 -0500 In-Reply-To: <20131210064624.GE12524@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Benjamin Tissoires , Linux Input , Andrew Duggan , Vincent Huang , Vivian Ly , Daniel Rosenberg , Jean Delvare , Joerie de Gram , Linus Walleij On 12/09/2013 10:46 PM, Dmitry Torokhov wrote: > On Mon, Dec 09, 2013 at 10:39:14PM -0800, Dmitry Torokhov wrote: >> On Mon, Dec 09, 2013 at 03:14:26PM -0500, Benjamin Tissoires wrote: >>> Hi Chris, >>> >>> On 05/12/13 19:29, Christopher Heiny wrote: >>>> This patch implements changes to the synaptics-rmi4 branch of >>>> Dmitry's input tree. The base for the patch is commit >>>> 8ca01dc61a42b6f7bcba052a8c084000f7057a34. >>>> >>>> This patch primarily reorders the various declarations in rmi_bus.= c in order to >>>> group related elements together, along with some typo fixes. The = code is still >>>> horribly broken, but this change should make the following fixes e= asier to >>>> review. >>>> >>>> Signed-off-by: Christopher Heiny >>>> Cc: Dmitry Torokhov >>>> Cc: Jean Delvare >>>> Cc: Linus Walleij >>>> Cc: Joerie de Gram >>>> Cc: Benjamin Tissoires >>>> >>>> --- >>> >>> FWIW, I made a review of the patch. >>> The patches does not only reorder the functions, but also fix some = few >>> things I will detail later (plus fixes of whitespace/comments issue= s). >>> It also changes the exported functions as GPL. >>> >>> Dmitry, given the current state of the driver (which does not work = at >>> all if I understood correctly), maybe you can pick this one in its >>> current state. >> >> Applied, thank you. >=20 > Well, I had to pull up rmi_debugfs_root declaration to avoid: >=20 > CC [M] drivers/input/rmi4/rmi_driver.o > drivers/input/rmi4/rmi_bus.c: In function =E2=80=98rmi_physical_setup= _debugfs=E2=80=99: > drivers/input/rmi4/rmi_bus.c:51:10: error: =E2=80=98rmi_debugfs_root=E2= =80=99 undeclared > (first use in this function) > rmi_debugfs_root); >=20 > Guys, a bit better compile coverage would be appreciated. Um, well, OK. As mentioned in a previous patch, the code is still horribly broken, although it's getting better. I should have included that previous patch's disclaimer with this one. There's a bunch of debugfs problems in the branch as it stands, such as failure to compile in certain configurations, kernel panics in others, problematic initialization sequence, and so on. I was planning to fix all that in a separate patch following this one, rather than putting changes in piece meal, or piggybacking the changes onto another patch. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html