From: Simon Budig <simon.budig@kernelconcepts.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>,
linux-input@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Rob Landley" <rob@landley.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Grant Likely" <grant.likely@linaro.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Silvio F" <silvio.fricke@gmail.com>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
"Jingoo Han" <jg1.han@samsung.com>,
"Fugang Duan" <B38611@freescale.com>,
"Sachin Kamat" <sachin.kamat@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support
Date: Fri, 17 Jan 2014 02:46:22 +0100 [thread overview]
Message-ID: <52D88B6E.6010709@kernelconcepts.de> (raw)
In-Reply-To: <20140117002649.GA837@core.coreip.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
Hi Dmitry
On 17/01/14 01:26, Dmitry Torokhov wrote:
>> + The following properties provide default values for the
>> + corresponding parameters (see Documentation/input/edt-ft5x06.txt)
>> +- edt,threshold: allows setting the "click"-threshold in the range from 20 to 80.
>> +- edt,gain: sensitivity (0..31) (lower value -> higher sensitivity)
>> +- edt,offset: edge compensation (0..31)
>> +- edt,report-rate: report rate (3..14)
>
> I wonder if we really need to have it in device tree? Can users needing
> top tweak the settings do it via udev rules?
IMO it makes sense to have these in the device tree. These values need
to be adjusted if you have glass or acrylics in front of the touch
glass. The defaults are tailored to the touchscreen without any
(additional) material in front of it.
So manufacturers need to provide different defaults depending on the way
a specific device is built. So these properties can be viewed in the
same way you specify display resolution or display type in the device tree.
Bye,
Simon
--
Simon Budig kernel concepts GmbH
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-01-17 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 8:02 [PATCHv2 0/3] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-16 8:02 ` [PATCHv2 1/3] Input: edt_ft5x06: use devm_* functions where appropriate Lothar Waßmann
2014-01-17 0:28 ` Dmitry Torokhov
2014-01-16 8:02 ` [PATCHv2 2/3] DT: Add vendor prefix for Emerging Display Technologies Lothar Waßmann
2014-01-16 8:02 ` [PATCHv2 3/3] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-17 0:26 ` Dmitry Torokhov
2014-01-17 1:36 ` Jingoo Han
2014-01-17 1:46 ` Simon Budig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D88B6E.6010709@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=B38611@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=silvio.fricke@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).