From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [patch] Input: remove a duplicative NULL test Date: Wed, 19 Mar 2014 16:02:05 +0000 Message-ID: <5329BF7D.8080007@itdev.co.uk> References: <20140221085506.GB13185@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:15443 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757750AbaCSQCU (ORCPT ); Wed, 19 Mar 2014 12:02:20 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benson Leung , "fugang.duan@freescale.com" Cc: Dan Carpenter , Dmitry Torokhov , Paul Gortmaker , Jingoo Han , Daniel Kurtz , "linux-input@vger.kernel.org" , "kernel-janitors@vger.kernel.org" > On Fri, Feb 21, 2014 at 1:14 AM, fugang.duan@freescale.com > wrote: >> >> Agree, it is redundant. And if you have free time, you can convert >> the driver to support devicetree. > > Please check with Nick Dyer before you convert this driver to support > devicetree. Much of the platform data this driver uses has been > eliminated or consolidated in a patch series that he's been working > on. If you look at the "improve T19 GPIO keys handling" patch in the patch set I posted to linux-input on 17th March, this redundant NULL test has been removed. I want to remove most of the existing platform data since it is not generic across all chips - see "remove unnecessary platform data" and "read screen config from chip" in that series of patches. It's high priority on my list to implement device tree support for the remaining items, which will be just irqflags and the touchpad key config.