From: Peter Hutterer <peter.hutterer@redhat.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>,
Hans de Goede <hdegoede@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <btissoir@redhat.com>,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute
Date: Mon, 24 Mar 2014 11:07:33 +1000 [thread overview]
Message-ID: <532F8555.5070701@redhat.com> (raw)
In-Reply-To: <20140320172159.GA27400@srcf.ucam.org>
On 21/03/14 03:21, Matthew Garrett wrote:
> On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote:
>
>> Which in the end turns out to be much nicer too, since it gets rid of needing
>> a udev-helper too. After this much too long introduction I'll let the patches
>> speak for themselves.
>
> Yeah, I was coming to the conclusion that this was probably the best we
> could do. It's unfortunate that "id" is already in use - we'd be able to
> get away without any X server modifications otherwise.
IMO we don't need to worry about that. this is needed for a set of
devices that need a kernel patch, several synaptics patches and a server
patch to work properly anyway, so changes are already required. Approach
looks good, ACK from me.
Cheers,
Peter
>
> Long term we probably still want to tie serio devices to the ACPI
> devices in case the vendor provides power management calls there, but we
> can leave that until there's an actual example.
>
next prev parent reply other threads:[~2014-03-24 1:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 10:12 [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Hans de Goede
2014-03-20 10:12 ` [PATCH 1/2] " Hans de Goede
2014-03-20 10:12 ` [PATCH 2/2] input/serio/8042: Add firmware_id support Hans de Goede
2014-03-20 17:21 ` [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute Matthew Garrett
2014-03-24 1:07 ` Peter Hutterer [this message]
2014-03-28 7:56 ` Dmitry Torokhov
2014-03-28 8:12 ` Hans de Goede
2014-03-28 8:17 ` Dmitry Torokhov
2014-03-28 8:29 ` Hans de Goede
2014-03-28 8:52 ` Dmitry Torokhov
2014-03-28 9:00 ` Matthew Garrett
2014-03-28 16:04 ` Dmitry Torokhov
2014-03-28 9:05 ` Hans de Goede
2014-03-28 8:20 ` Matthew Garrett
2014-03-28 8:24 ` Dmitry Torokhov
2014-03-28 8:27 ` Matthew Garrett
2014-03-28 8:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532F8555.5070701@redhat.com \
--to=peter.hutterer@redhat.com \
--cc=btissoir@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).