From: "Zhu, Lejun" <lejun.zhu@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: misc: Add driver for Intel Bay Trail GPIO buttons
Date: Thu, 27 Mar 2014 09:09:00 +0800 [thread overview]
Message-ID: <53337A2C.9020805@linux.intel.com> (raw)
In-Reply-To: <20140326202029.GB11013@core.coreip.homeip.net>
On 3/27/2014 4:20 AM, Dmitry Torokhov wrote:
> On Wed, Mar 26, 2014 at 05:04:04PM +0000, One Thousand Gnomes wrote:
>> On Wed, 26 Mar 2014 13:01:36 +0800
>> "Zhu, Lejun" <lejun.zhu@linux.intel.com> wrote:
>>
>>> This patch adds support for the GPIO buttons on some Intel Bay Trail
>>> tablets originally running Windows 8. The ACPI description of these
>>> buttons follows "Windows ACPI Design Guide for SoC Platforms".
>>
>> I'm not sure calling it "Baytrail" is right here - it's in theory a
>> generic interface so probably should be named accordingly
>>
>> Otherwise looks good to me.
>
> It uses static devices in non-board code - if I unbind and rebind PNP
> device that produces gpio-keys platform devices driver core will not be
> happy.
>
> Thanks.
>
Alan, I will think of a better name for it. This is supposed to work for
other "win8 ready" tablets as well, just all I have today are Baytrail
tablets.
Dmitry, thank you for pointing out the bug. I'll fix it and submit again.
Thanks.
Lejun
prev parent reply other threads:[~2014-03-27 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <533259F7.3050908@linux.intel.com>
2014-03-26 5:01 ` [PATCH] input: misc: Add driver for Intel Bay Trail GPIO buttons Zhu, Lejun
2014-03-26 17:04 ` One Thousand Gnomes
2014-03-26 20:20 ` Dmitry Torokhov
2014-03-27 1:09 ` Zhu, Lejun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53337A2C.9020805@linux.intel.com \
--to=lejun.zhu@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).