Re: [PATCH v3 2/8] HID: sony: Set the quriks flag for Bluetooth controllers

[andrea <mariofutire@gmail.com>]

On 15/03/14 13:41, Frank Praznik wrote:
> The Sixaxis and DualShock 4 want HID output reports sent on the control
> endpoint when connected via Bluetooth.  Set the
> HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP flag for these devices so hidraw write()
> works properly.
> 
> Signed-off-by: Frank Praznik <frank.praznik@oh.rr.com>
> ---
>  drivers/hid/hid-sony.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index 4c445a0..908de27 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -1632,11 +1632,21 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  		sc->worker_initialized = 1;
>  		INIT_WORK(&sc->state_worker, sixaxis_state_worker);
>  	} else if (sc->quirks & SIXAXIS_CONTROLLER_BT) {
> +		/*
> +		 * The Sixaxis wants output reports sent on the ctrl endpoint
> +		 * when connected via Bluetooth.
> +		 */
> +		hdev->quirks |= HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP;
>  		ret = sixaxis_set_operational_bt(hdev);
>  		sc->worker_initialized = 1;
>  		INIT_WORK(&sc->state_worker, sixaxis_state_worker);
>  	} else if (sc->quirks & DUALSHOCK4_CONTROLLER) {
>  		if (sc->quirks & DUALSHOCK4_CONTROLLER_BT) {
> +			/*
> +			 * The DualShock 4 wants output reports sent on the ctrl
> +			 * endpoint when connected via Bluetooth.
> +			 */
> +			hdev->quirks |= HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP;
>  			ret = dualshock4_set_operational_bt(hdev);
>  			if (ret < 0) {
>  				hid_err(hdev, "failed to set the Dualshock 4 operational mode\n");
> 

I am simply a user of a Sixaxis via Bluetooth and it would be super to have this patch applied and
merged in 3.15
We always need to modify the BT stack in the vanilla kernel using an old hack Frank proposed.

This would make things a lot simpler and less painful.

I don't know about the other 7, but this one would get my vote (if I had one...)

Andrea