From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Bauer Subject: Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage Date: Thu, 13 Jun 2019 13:48:52 +0200 Message-ID: <5346893.KeHrH3GHoD@linux-lf90.site> References: <20190611121320.30267-1-nsaenzjulienne@suse.de> Reply-To: wbauer1@a1.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Tissoires Cc: Nicolas Saenz Julienne , Jiri Kosina , Dmitry Torokhov , "open list:HID CORE LAYER" , lkml List-Id: linux-input@vger.kernel.org On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoires wrote: > On Tue, Jun 11, 2019 at 2:13 PM Nicolas Saenz Julienne > > wrote: > > NOTE: I CC'd Wolfgang as he's the one who can test this. > > I'll wait for Wolfram to confirm that the patch works before pushing then. My name is Wolfgang, not Wolfram... ;-) But never mind. I tested the patch meanwhile on top of kernel 5.2.rc4, where the mouse wheel actually worked. As the patch didn't apply cleanly (it's obviously based upon https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=abf82e8f7e9af40a49e3d905187c662a43c96c8f , called "HID- a4tech-fix-horizontal-scrolling.patch" below), I added that patch as well. My results: kernel 5.2.rc4 works kernel 5.2.rc4 + HID-a4tech-fix-horizontal-scrolling.patch is broken kernel 5.2.rc4 + HID-a4tech-fix-horizontal-scrolling.patch + HID-input-fix-a4tech-horizontal-wheel-custom-usage.patch (i.e. this patch) works again kernel 5.2.rc4 + HID-input-fix-a4tech-horizontal-wheel-custom-usage.patch works as well. So AFAICT this patch seems to be fine. For completeness, this is my mouse as listed by lsusb: Bus 003 Device 002: ID 09da:000a A4Tech Co., Ltd. Optical Mouse Opto 510D / OP-620D Kind Regards, Wolfgang