From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] input: atmel-wm97xx: only build for AVR32
Date: Mon, 12 May 2014 15:16:45 +0200 [thread overview]
Message-ID: <5370C9BD.4040201@atmel.com> (raw)
In-Reply-To: <1399560990-1402858-16-git-send-email-arnd@arndb.de>
On 08/05/2014 16:56, Arnd Bergmann :
> Building this driver on ARM/at91 always gives us this error message:
>
> drivers/input/touchscreen/atmel-wm97xx.c:63:2: error: #error Unknown CPU, this driver only supports AT32AP700X CPUs.
>
> Clearly this configuration is not meant to work, so let's just prevent
> it in Kconfig. If we ever want to use it on another platform, we should
> also pass proper resources for GPIO, IRQ and memory, which are hardcoded
> to AT32AP700X at the moment.
Yes it seems so:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/input/touchscreen/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index e2f0264..fe4c264 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -640,7 +640,7 @@ config TOUCHSCREEN_WM9713
>
> config TOUCHSCREEN_WM97XX_ATMEL
> tristate "WM97xx Atmel accelerated touch"
> - depends on TOUCHSCREEN_WM97XX && (AVR32 || ARCH_AT91)
> + depends on TOUCHSCREEN_WM97XX && AVR32
> help
> Say Y here for support for streaming mode with WM97xx touchscreens
> on Atmel AT91 or AVR32 systems with an AC97C module.
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-05-12 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
2014-05-08 14:56 ` [PATCH 1/2] input: fix ps2/serio module dependency Arnd Bergmann
2014-05-08 15:59 ` Dmitry Torokhov
2014-05-09 7:34 ` Arnd Bergmann
2014-05-08 14:56 ` [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 Arnd Bergmann
2014-05-12 13:16 ` Nicolas Ferre [this message]
[not found] ` <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
2014-05-09 11:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370C9BD.4040201@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).