* [PATCH 00/22] Random ARM randconfig fixes in drivers @ 2014-05-08 14:46 Arnd Bergmann [not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de> [not found] ` <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org> 0 siblings, 2 replies; 8+ messages in thread From: Arnd Bergmann @ 2014-05-08 14:46 UTC (permalink / raw) To: linux-arm-kernel Cc: linux-kernel, Arnd Bergmann, bhelgaas, dwmw2, dmitry.torokhov, balbi, gregkh, plagnioj, jic23, josh.wu, kishon, linus.walleij, broonie, mturquette, nicolas.ferre, ohad, linux, tony, vinod.koul, wim, wsa, dmaengine, linux-i2c, linux-ide, linux-iio, linux-input, linux-mtd, linux-pci, linux-samsung-soc, linux-sh, linux-watchdog, netdev These are a bunch of fixes I had to do to get all randconfig configurations on ARM working. Most of these are really old bugs, but there are also some new ones. I don't think any of them require a backport to linux-stable. I have checked that they are all still required on yesterday's linux-next kernel. Please apply on the appropriate trees unless there are objections. Patch numbers are per subsystem, which I thought is less confusing than numbering them 1-22 when they are all totall independent. Arnd Bergmann (22): mdio_bus: fix devm_mdiobus_alloc_size export phy: kona2: use 'select GENERIC_PHY' in Kconfig phy: exynos: fix SATA phy license typo dmaengine: omap: hide filter_fn for built-in drivers dmaengine: sa11x0: remove broken #ifdef mtd/onenand: fix build warning for dma type mtd: orion-nand: fix build error with ARMv4 clk/versatile: export symbols for impd1 bus/omap_l3: avoid sync initcall for modules bus/arm-cci: add dependency on OF && CPU_V7 watchdog: iop_wdt only builds for mach-iop13xx mpilib: use 'static inline' for mpi-inline.h ata: pata_at91 only works on sam9 i2c/nuc900: fix ancient build error iio: always select ANON_INODES iio:adc: at91 requires the input subsystem pci: rcar host needs OF input: fix ps2/serio module dependency input: atmel-wm97xx: only build for AVR32 misc: atmel_pwm: only build for supported platforms remoteproc: da8xx: don't select CMA on no-MMU regulator: arizona-ldo1: add missing #include drivers/ata/Kconfig | 2 +- drivers/bus/Kconfig | 2 +- drivers/bus/omap_l3_noc.c | 4 ++++ drivers/bus/omap_l3_smx.c | 4 ++++ drivers/clk/versatile/clk-icst.c | 1 + drivers/clk/versatile/clk-impd1.c | 2 ++ drivers/dma/sa11x0-dma.c | 4 ---- drivers/i2c/busses/i2c-nuc900.c | 2 +- drivers/iio/Kconfig | 1 + drivers/iio/adc/Kconfig | 1 + drivers/input/keyboard/Kconfig | 2 +- drivers/input/mouse/Kconfig | 2 +- drivers/input/touchscreen/Kconfig | 2 +- drivers/misc/Kconfig | 3 ++- drivers/mtd/nand/orion_nand.c | 5 +++++ drivers/mtd/onenand/samsung.c | 8 ++++---- drivers/net/phy/mdio_bus.c | 2 +- drivers/pci/host/Kconfig | 2 +- drivers/phy/Kconfig | 2 +- drivers/phy/phy-exynos5250-sata.c | 2 +- drivers/regulator/arizona-ldo1.c | 1 + drivers/remoteproc/Kconfig | 2 +- drivers/watchdog/Kconfig | 2 +- include/linux/omap-dma.h | 2 +- lib/mpi/mpi-inline.h | 2 +- lib/mpi/mpi-internal.h | 8 -------- 26 files changed, 39 insertions(+), 31 deletions(-) -- 1.8.3.2 Cc: bhelgaas@google.com Cc: dwmw2@infradead.org Cc: dmitry.torokhov@gmail.com Cc: balbi@ti.com Cc: gregkh@linuxfoundation.org Cc: plagnioj@jcrosoft.com Cc: jic23@kernel.org Cc: josh.wu@atmel.com Cc: kishon@ti.com Cc: linus.walleij@linaro.org Cc: broonie@kernel.org Cc: mturquette@linaro.org Cc: nicolas.ferre@atmel.com Cc: ohad@wizery.com Cc: linux@arm.linux.org.uk Cc: tony@atomide.com Cc: vinod.koul@intel.com Cc: wim@iguana.be Cc: wsa@the-dreams.de Cc: dmaengine@vger.kernel.org Cc: linux-i2c@vger.kernel.org Cc: linux-ide@vger.kernel.org Cc: linux-iio@vger.kernel.org Cc: linux-input@vger.kernel.org Cc: linux-mtd@lists.infradead.org Cc: linux-pci@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: linux-watchdog@vger.kernel.org Cc: netdev@vger.kernel.org ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <1399560990-1402858-1-git-send-email-arnd@arndb.de>]
* [PATCH 1/2] input: fix ps2/serio module dependency [not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de> @ 2014-05-08 14:56 ` Arnd Bergmann 2014-05-08 15:59 ` Dmitry Torokhov 2014-05-08 14:56 ` [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 Arnd Bergmann 1 sibling, 1 reply; 8+ messages in thread From: Arnd Bergmann @ 2014-05-08 14:56 UTC (permalink / raw) To: linux-arm-kernel Cc: linux-kernel, Arnd Bergmann, Dmitry Torokhov, linux-input The ps2 mouse and keyboard drivers use the "serio" framework that they correctly select in Kconfig, and that in turn depends on the i8042 driver, which is also allowed to be disabled for architectures that don't have an i8042. However, Kconfig also allows i8042 to be built as a module while the serio framework is built-in, which causes this link error: drivers/built-in.o: In function `ps2_begin_command': :(.text+0x26b6cc): undefined reference to `i8042_check_port_owner' :(.text+0x26b6d4): undefined reference to `i8042_lock_chip' drivers/built-in.o: In function `ps2_end_command': :(.text+0x26b734): undefined reference to `i8042_check_port_owner' :(.text+0x26b73c): undefined reference to `i8042_unlock_chip' On x86, a specific 'select SERIO_I8042' takes care of it, but not on the other architecture that potentially have a u8042. This patch changes the Kconfig logic to ensure that whenever there is an i8042, it does get used for the serio driver, avoiding the link error above. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org --- drivers/input/keyboard/Kconfig | 2 +- drivers/input/mouse/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 4f115db..dd2435a 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -71,7 +71,7 @@ config KEYBOARD_ATKBD default y select SERIO select SERIO_LIBPS2 - select SERIO_I8042 if X86 + select SERIO_I8042 if X86 || ARCH_MIGHT_HAVE_PC_SERIO select SERIO_GSCPS2 if GSC help Say Y here if you want to use a standard AT or PS/2 keyboard. Usually diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig index effa9c5..cf534ee 100644 --- a/drivers/input/mouse/Kconfig +++ b/drivers/input/mouse/Kconfig @@ -17,7 +17,7 @@ config MOUSE_PS2 default y select SERIO select SERIO_LIBPS2 - select SERIO_I8042 if X86 + select SERIO_I8042 if X86 || ARCH_MIGHT_HAVE_PC_SERIO select SERIO_GSCPS2 if GSC help Say Y here if you have a PS/2 mouse connected to your system. This -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] input: fix ps2/serio module dependency 2014-05-08 14:56 ` [PATCH 1/2] input: fix ps2/serio module dependency Arnd Bergmann @ 2014-05-08 15:59 ` Dmitry Torokhov 2014-05-09 7:34 ` Arnd Bergmann 0 siblings, 1 reply; 8+ messages in thread From: Dmitry Torokhov @ 2014-05-08 15:59 UTC (permalink / raw) To: Arnd Bergmann; +Cc: linux-arm-kernel, linux-kernel, linux-input Hi Arnd, On Thu, May 08, 2014 at 04:56:26PM +0200, Arnd Bergmann wrote: > @@ -71,7 +71,7 @@ config KEYBOARD_ATKBD > default y > select SERIO > select SERIO_LIBPS2 > - select SERIO_I8042 if X86 > + select SERIO_I8042 if X86 || ARCH_MIGHT_HAVE_PC_SERIO x86 also selects ARCH_MIGHT_HAVE_PC_SERIO so shouldn't this be select SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO ? I can fix it up on my side if you agree. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] input: fix ps2/serio module dependency 2014-05-08 15:59 ` Dmitry Torokhov @ 2014-05-09 7:34 ` Arnd Bergmann 0 siblings, 0 replies; 8+ messages in thread From: Arnd Bergmann @ 2014-05-09 7:34 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-arm-kernel, linux-kernel, linux-input On Thursday 08 May 2014 08:59:31 Dmitry Torokhov wrote: > Hi Arnd, > > On Thu, May 08, 2014 at 04:56:26PM +0200, Arnd Bergmann wrote: > > @@ -71,7 +71,7 @@ config KEYBOARD_ATKBD > > default y > > select SERIO > > select SERIO_LIBPS2 > > - select SERIO_I8042 if X86 > > + select SERIO_I8042 if X86 || ARCH_MIGHT_HAVE_PC_SERIO > > x86 also selects ARCH_MIGHT_HAVE_PC_SERIO so shouldn't this be > > select SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO > > ? > > I can fix it up on my side if you agree. Yes, sounds good, thanks! Arnd ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 [not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de> 2014-05-08 14:56 ` [PATCH 1/2] input: fix ps2/serio module dependency Arnd Bergmann @ 2014-05-08 14:56 ` Arnd Bergmann 2014-05-12 13:16 ` Nicolas Ferre 1 sibling, 1 reply; 8+ messages in thread From: Arnd Bergmann @ 2014-05-08 14:56 UTC (permalink / raw) To: linux-arm-kernel Cc: Arnd Bergmann, Dmitry Torokhov, linux-kernel, Mark Brown, linux-input, Liam Girdwood Building this driver on ARM/at91 always gives us this error message: drivers/input/touchscreen/atmel-wm97xx.c:63:2: error: #error Unknown CPU, this driver only supports AT32AP700X CPUs. Clearly this configuration is not meant to work, so let's just prevent it in Kconfig. If we ever want to use it on another platform, we should also pass proper resources for GPIO, IRQ and memory, which are hardcoded to AT32AP700X at the moment. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Mark Brown <broonie@kernel.org> Cc: Liam Girdwood <lrg@slimlogic.co.uk> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org --- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index e2f0264..fe4c264 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -640,7 +640,7 @@ config TOUCHSCREEN_WM9713 config TOUCHSCREEN_WM97XX_ATMEL tristate "WM97xx Atmel accelerated touch" - depends on TOUCHSCREEN_WM97XX && (AVR32 || ARCH_AT91) + depends on TOUCHSCREEN_WM97XX && AVR32 help Say Y here for support for streaming mode with WM97xx touchscreens on Atmel AT91 or AVR32 systems with an AC97C module. -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 2014-05-08 14:56 ` [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 Arnd Bergmann @ 2014-05-12 13:16 ` Nicolas Ferre 0 siblings, 0 replies; 8+ messages in thread From: Nicolas Ferre @ 2014-05-12 13:16 UTC (permalink / raw) To: Arnd Bergmann, linux-arm-kernel, Dmitry Torokhov, linux-input, Liam Girdwood Cc: linux-kernel, Mark Brown On 08/05/2014 16:56, Arnd Bergmann : > Building this driver on ARM/at91 always gives us this error message: > > drivers/input/touchscreen/atmel-wm97xx.c:63:2: error: #error Unknown CPU, this driver only supports AT32AP700X CPUs. > > Clearly this configuration is not meant to work, so let's just prevent > it in Kconfig. If we ever want to use it on another platform, we should > also pass proper resources for GPIO, IRQ and memory, which are hardcoded > to AT32AP700X at the moment. Yes it seems so: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Mark Brown <broonie@kernel.org> > Cc: Liam Girdwood <lrg@slimlogic.co.uk> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org > --- > drivers/input/touchscreen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > index e2f0264..fe4c264 100644 > --- a/drivers/input/touchscreen/Kconfig > +++ b/drivers/input/touchscreen/Kconfig > @@ -640,7 +640,7 @@ config TOUCHSCREEN_WM9713 > > config TOUCHSCREEN_WM97XX_ATMEL > tristate "WM97xx Atmel accelerated touch" > - depends on TOUCHSCREEN_WM97XX && (AVR32 || ARCH_AT91) > + depends on TOUCHSCREEN_WM97XX && AVR32 > help > Say Y here for support for streaming mode with WM97xx touchscreens > on Atmel AT91 or AVR32 systems with an AC97C module. > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>]
* Re: [PATCH 00/22] Random ARM randconfig fixes in drivers [not found] ` <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org> @ 2014-05-08 16:41 ` Guenter Roeck 2014-05-09 11:48 ` Arnd Bergmann 0 siblings, 1 reply; 8+ messages in thread From: Guenter Roeck @ 2014-05-08 16:41 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w, balbi-l0cyMroinI0, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, plagnioj-sclMFOaUSTBWk0Htik3J/w, jic23-DgEjT+Ai2ygdnm+yROfE0A, josh.wu-AIFe0yeh4nAAvxtiuMwx3w, kishon-l0cyMroinI0, linus.walleij-QSEj5FYQhm4dnm+yROfE0A, broonie-DgEjT+Ai2ygdnm+yROfE0A, mturquette-QSEj5FYQhm4dnm+yROfE0A, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, ohad-Ix1uc/W3ht7QT0dZR+AlfA, linux-lFZ/pmaqli7XmaaqVzeoHQ, tony-4v6yS6AI5VpBDgjK7y7TUQ, vinod.koul-ral2JQCrhuEAvxtiuMwx3w, wim-IQzOog9fTRqzQB+pC5nmwQ, wsa-z923LK4zBo2bacvFa/9K2g, dmaengine-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-ide-u79uwXL29TY76Z2rM5mHXA, linux-iio-u79uwXL29TY76Z2rM5mHXA, linux-input-u79uwXL29TY76Z2rM5mHXA, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-pci-u79uwXL29TY76Z2rM5mHXA, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA On Thu, May 08, 2014 at 04:46:51PM +0200, Arnd Bergmann wrote: > These are a bunch of fixes I had to do to get all randconfig > configurations on ARM working. Most of these are really old > bugs, but there are also some new ones. I don't think any of > them require a backport to linux-stable. > > I have checked that they are all still required on yesterday's > linux-next kernel. Please apply on the appropriate trees unless > there are objections. > Is this series of patches also going to fix arm:allmodconfig ? Thanks, Guenter ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] Random ARM randconfig fixes in drivers 2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck @ 2014-05-09 11:48 ` Arnd Bergmann 0 siblings, 0 replies; 8+ messages in thread From: Arnd Bergmann @ 2014-05-09 11:48 UTC (permalink / raw) To: Guenter Roeck Cc: wsa, tony, linux-pci, linus.walleij, nicolas.ferre, linux-ide, wim, linux-mtd, linux-i2c, linux-samsung-soc, mturquette, vinod.koul, linux-sh, kishon, linux-iio, linux-input, plagnioj, ohad, linux-watchdog, broonie, bhelgaas, linux, linux-arm-kernel, gregkh, dmitry.torokhov, linux-kernel, balbi, josh.wu, netdev, dmaengine, dwmw2, jic23 On Thursday 08 May 2014, Guenter Roeck wrote: > On Thu, May 08, 2014 at 04:46:51PM +0200, Arnd Bergmann wrote: > > These are a bunch of fixes I had to do to get all randconfig > > configurations on ARM working. Most of these are really old > > bugs, but there are also some new ones. I don't think any of > > them require a backport to linux-stable. > > > > I have checked that they are all still required on yesterday's > > linux-next kernel. Please apply on the appropriate trees unless > > there are objections. > > > Is this series of patches also going to fix arm:allmodconfig ? Possibly, I haven't checked in a while. I'm unfortunately sitting on about 200 other patches in the same branch, which together fix all build errors in any configuration I encountered. I should really do some allmodconfig/allnoconfig/allyesconfig builds without my series again, and prioritize sending out the ones required for that. Arnd ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-12 13:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann [not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de> 2014-05-08 14:56 ` [PATCH 1/2] input: fix ps2/serio module dependency Arnd Bergmann 2014-05-08 15:59 ` Dmitry Torokhov 2014-05-09 7:34 ` Arnd Bergmann 2014-05-08 14:56 ` [PATCH 2/2] input: atmel-wm97xx: only build for AVR32 Arnd Bergmann 2014-05-12 13:16 ` Nicolas Ferre [not found] ` <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org> 2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck 2014-05-09 11:48 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).