From: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v4 6/9] regulator: AXP20x: Add support for regulators subsystem
Date: Thu, 15 May 2014 20:03:06 +0200 [thread overview]
Message-ID: <5375015A.10701@free-electrons.com> (raw)
In-Reply-To: <1397209093-10077-7-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
Hello Carlo,
On 11/04/2014 11:38, Carlo Caione wrote:
> AXP202 and AXP209 come with two synchronous step-down DC-DCs and five
> LDOs. This patch introduces basic support for those regulators.
>
> Signed-off-by: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
> ---
> drivers/regulator/Kconfig | 7 +
> drivers/regulator/Makefile | 1 +
[...]
> + if (!np)
> + return 0;
> +
> + regulators = of_find_node_by_name(np, "regulators");
I know I'm late, and this patch has already been applied, but shouldn't
we use of_get_child_by_name instead of of_find_node_by_name.
This might lead to wrong regulators node parsing if other regulators are
defined in the DT after the axp20x node, because, AFAIK, this function
searches for DT nodes defined after the specified np node, but not
necessarely children of the np node.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-15 18:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 9:38 [PATCH v4 0/9] mfd: AXP20x: Add support for AXP202 and AXP209 Carlo Caione
[not found] ` <1397209093-10077-1-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-04-11 9:38 ` [PATCH v4 1/9] mfd: AXP20x: Add mfd driver for AXP20x PMIC Carlo Caione
[not found] ` <1397209093-10077-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-04-11 11:25 ` Arnd Bergmann
2014-04-11 12:03 ` [linux-sunxi] " Carlo Caione
2014-04-11 12:09 ` Mark Brown
[not found] ` <20140411120908.GC28800-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-04-11 13:16 ` Arnd Bergmann
2014-04-16 15:43 ` Lee Jones
2014-04-16 15:44 ` Lee Jones
2014-04-11 9:38 ` [PATCH v4 2/9] dt-bindings: add vendor-prefix for X-Powers Carlo Caione
2014-04-11 9:38 ` [PATCH v4 3/9] mfd: AXP20x: Add bindings documentation Carlo Caione
2014-04-11 9:38 ` [PATCH v4 4/9] input: misc: Add driver for AXP20x Power Enable Key Carlo Caione
[not found] ` <1397209093-10077-5-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-04-13 8:17 ` Dmitry Torokhov
2014-04-17 12:07 ` [linux-sunxi] " Carlo Caione
2014-04-11 9:38 ` [PATCH v4 5/9] input: misc: Add ABI docs for AXP20x PEK Carlo Caione
2014-04-11 9:38 ` [PATCH v4 6/9] regulator: AXP20x: Add support for regulators subsystem Carlo Caione
[not found] ` <1397209093-10077-7-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-04-11 12:23 ` Mark Brown
2014-04-11 12:29 ` [linux-sunxi] " Carlo Caione
2014-05-15 18:03 ` Boris BREZILLON [this message]
[not found] ` <5375015A.10701-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-15 18:18 ` Mark Brown
2014-05-16 7:40 ` Carlo Caione
2014-04-11 9:38 ` [PATCH v4 7/9] ARM: sun7i/sun4i: dt: Add AXP209 support to various boards Carlo Caione
[not found] ` <1397209093-10077-8-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2014-04-11 12:29 ` Mark Brown
2014-04-11 13:04 ` Carlo Caione
[not found] ` <CAOQ7t2Y2B7f+eZApDHKiKm9=bOXo6oUA2RLY7ENn7qPLQEboMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-11 16:18 ` Mark Brown
[not found] ` <20140411161813.GF28800-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-04-17 10:06 ` Carlo Caione
[not found] ` <CAOQ7t2YO_MjUZkkoEe1Grft+fVttWoOro85Sru2P3LXbx8Kjbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-18 15:15 ` Mark Brown
[not found] ` <20140418151551.GZ12304-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-04-23 20:25 ` Carlo Caione
[not found] ` <20140423202546.GA3890-OP/Sd6KM9CusbfqNwF1Yyl6hYfS7NtTn@public.gmane.org>
2014-04-24 13:30 ` Mark Brown
2014-04-24 16:35 ` Charles Keepax
[not found] ` <20140424163523.GB25663-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2014-04-24 16:58 ` Charles Keepax
[not found] ` <20140424165847.GC25663-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2014-04-24 17:12 ` Mark Brown
2014-04-14 9:52 ` Maxime Ripard
2014-04-14 10:02 ` Carlo Caione
[not found] ` <CAOQ7t2ZybF=dm-NBQ3niN7gb-Asgwz5CW-VSkOzWR6t2NCaA8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-14 10:20 ` Hans de Goede
[not found] ` <534BB670.8030102-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-14 11:16 ` Mark Brown
2014-04-11 9:38 ` [PATCH v4 8/9] ARM: sunxi: Add AXP20x support in defconfig Carlo Caione
2014-04-11 9:38 ` [PATCH v4 9/9] ARM: sunxi: Add AXP20x support multi_v7_defconfig Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5375015A.10701@free-electrons.com \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).