From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 20/51] Input: atmel_mxt_ts - Set default irqflags when there is no pdata Date: Thu, 22 May 2014 15:29:42 +0100 Message-ID: <537E09D6.7050604@itdev.co.uk> References: <1372337366-9286-1-git-send-email-nick.dyer@itdev.co.uk> <1372337366-9286-21-git-send-email-nick.dyer@itdev.co.uk> <20130718171744.GC32381@polaris.bitmath.org> <20130916022533.GA6468@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:56676 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751374AbaEVO3r (ORCPT ); Thu, 22 May 2014 10:29:47 -0400 In-Reply-To: <20130916022533.GA6468@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benson Leung , Yufeng Shen Cc: Dmitry Torokhov , rydberg@euromail.se, Daniel Kurtz , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Olof Johansson Dmitry Torokhov wrote: > On Thu, Jul 18, 2013 at 07:17:44PM +0200, rydberg@euromail.se wrote: >>> From: Yufeng Shen >>> This is the preparation for supporting the code path when there is >>> platform data provided and still boot the device into a sane state >>> with backup NVRAM config. >>> >>> Make the irqflags default to be IRQF_TRIGGER_FALLING if no platform data is >>> provided. > > I think if there is no platform data we should use 0 as IRQ falgs and > assume that IRQ line is properly configured by the board code or via > device tree. Beson/Yufeng - do you still have a requirement to probe without platform data or device tree? I'm just merging in some changes to add device tree support, and it would simplify things a bit if I can drop this patch.