From: Hans de Goede <hdegoede@redhat.com>
To: Ulrik De Bie <ulrik.debie-os@e2big.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v4 2/2] elantech: Call psmouse_reset when elantech probe fails
Date: Tue, 17 Jun 2014 08:08:40 +0200 [thread overview]
Message-ID: <539FDB68.5040804@redhat.com> (raw)
In-Reply-To: <1402955589-23709-3-git-send-email-ulrik.debie-os@e2big.org>
Hi,
On 06/16/2014 11:53 PM, Ulrik De Bie wrote:
> elantech_init() calls elantech_set_absolute_mode which sets the driver in
> an absolute mode. When after this the elantech_init fails, it is best
> to turn the ps/2 mouse emulation mode back on by calling psmouse_reset()
> so that it can work as a regular mouse.
>
> Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
Looks good, this patch is:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/input/mouse/elantech.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 5dd620a..771291c 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1620,6 +1620,7 @@ int elantech_init(struct psmouse *psmouse)
> sysfs_remove_group(&psmouse->ps2dev.serio->dev.kobj,
> &elantech_attr_group);
> init_fail:
> + psmouse_reset(psmouse);
> kfree(etd);
> return error;
> }
>
next prev parent reply other threads:[~2014-06-17 6:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140613205547.GA5244@lantern>
2014-06-13 21:21 ` [PATCH v3 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 Ulrik De Bie
2014-06-13 21:21 ` [PATCH v3 1/2] elantech: Add support for trackpoint found on some v3 models Ulrik De Bie
2014-06-16 8:42 ` David Herrmann
2014-06-16 21:53 ` [PATCH v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 Ulrik De Bie
2014-06-16 21:53 ` [PATCH v4 1/2] elantech: Add support for trackpoint found on some v3 models Ulrik De Bie
2014-06-16 21:53 ` [PATCH v4 2/2] elantech: Call psmouse_reset when elantech probe fails Ulrik De Bie
2014-06-17 6:08 ` Hans de Goede [this message]
2014-07-14 19:03 ` [PATCH v4 0/2] Input: Support in the elantech driver of the trackpoint present on for instance Lenovo L530 ulrik.debie-os
2014-06-13 21:21 ` [PATCH v3 2/2] elantech: Call psmouse_reset when elantech probe fails Ulrik De Bie
2014-06-16 8:44 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539FDB68.5040804@redhat.com \
--to=hdegoede@redhat.com \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).