From: Hans de Goede <hdegoede@redhat.com>
To: Jamie Lentin <jm@lentin.co.uk>, Jiri Kosina <jkosina@suse.cz>,
Antonio Ospite <ao2@ao2.it>
Cc: linux-usb <linux-input@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Mapping of F11 and F12 on new lenovo laptops and Lenovo Compact Keyboard
Date: Thu, 19 Jun 2014 10:41:21 +0200 [thread overview]
Message-ID: <53A2A231.4030700@redhat.com> (raw)
Hi Jamie,
I saw your patch-set for the Lenovo Compact Keyboard on the lwn.net
kernel page.
This spiked my interest as I'm the author of this patch:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/x86/thinkpad_acpi.c?id=8b9dd4fab26a0f328420cbda0845a325f45bcd92
Which adds mapping for the F9 - F12 on the Lenovo *40 series
laptops, which have the same weird symbols on F11 and F12 as the
Lenovo Compact Keyboard, the ones which you describe as:
/* Fn-F11: View open applications (3 boxes) */
/* Fn-F12: Open My computer (6 boxes) USB-only */
You map these to:
KEY_FN_F11
KEY_FILE
Where as my (already merged into Linus tree) patch maps these to:
KEY_SCALE
KEY_COMPUTER
Which are defined in linux/uapi/input.h as:
#define KEY_SCALE 120 /* AL Compiz Scale (Expose) */
#define KEY_COMPUTER 157
Which I believe maps closes to View open applications (which to me
sounds like expose mode) and Open My computer.
Note that on the laptops the keys have their special meaning by
default and using Fn turns them back into normal F11 keys, so
KEY_FN_F11 seems like a particular bad match as that suggests
a key combo which it is not on the laptops.
Anyways lets discuss and coordinate, so that we end up with the
same mappings for the weird symbols on F11 and F12 for the laptops
and for the Lenovo Compact Keyboard.
Regards,
Hans
next reply other threads:[~2014-06-19 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 8:41 Hans de Goede [this message]
2014-06-20 12:00 ` Mapping of F11 and F12 on new lenovo laptops and Lenovo Compact Keyboard Jamie Lentin
2014-06-20 12:44 ` Hans de Goede
2014-06-21 13:10 ` Jamie Lentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2A231.4030700@redhat.com \
--to=hdegoede@redhat.com \
--cc=ao2@ao2.it \
--cc=jkosina@suse.cz \
--cc=jm@lentin.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).