From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Li, Aubrey" Subject: Re: [PATCH] GPIO button wth wakeup attribute is supposed to wake the system up Date: Tue, 24 Jun 2014 07:35:46 +0800 Message-ID: <53A8B9D2.8090705@linux.intel.com> References: <53A2340D.9030503@linux.intel.com> <20140619114006.72ac8e06@alan.etchedpixels.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([192.55.52.115]:56218 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753864AbaFWXfx (ORCPT ); Mon, 23 Jun 2014 19:35:53 -0400 In-Reply-To: <20140619114006.72ac8e06@alan.etchedpixels.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: One Thousand Gnomes Cc: "dmitry.torokhov@gmail.com" , "Rafael J. Wysocki" , "linux-input@vger.kernel.org" , LKML ping... On 2014/6/19 18:40, One Thousand Gnomes wrote: > On Thu, 19 Jun 2014 08:51:25 +0800 > "Li, Aubrey" wrote: > >> When the wakeup attribute is set, the GPIO button is capable of >> waking up the system from sleep states, including the "freeze" >> sleep state. For that to work, its driver needs to pass the >> IRQF_NO_SUSPEND flag to devm_request_any_context_irq(), or the >> interrupt will be disabled by suspend_device_irqs() and the >> system won't be woken up by it from the "freeze" sleep state. >> >> The suspend_device_irqs() routine is a workaround for drivers >> that mishandle interrupts triggered when the devices handled >> by them are suspended, so it is safe to use IRQF_NO_SUSPEND in >> all drivers that don't have that problem. >> >> The affected/tested machines include Dell Venue 11 Pro and Asus T100TA. >> >> Signed-off-by: Aubrey Li >> Reviewed-by: Rafael J. Wysocki > > Reviewed-by: Alan Cox > > >