From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' Date: Tue, 22 Jul 2014 19:29:35 +0800 Message-ID: <53CE4B1F.9080701@gmail.com> References: <201407130545.23004.marex@denx.de> <53CB801D.1030603@gmail.com> <53CB8FC4.4050009@gmail.com> <179292068.QXZf3Zcqzf@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <179292068.QXZf3Zcqzf@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Arnd Bergmann Cc: linux-iio@vger.kernel.org, Benjamin Herrenschmidt , heiko.carstens@de.ibm.com, Tom Gundersen , Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , Lars-Peter Clausen , Richard Weinberger , Geert Uytterhoeven , msalter@redhat.com, Guenter Roeck , linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, linux-input@vger.kernel.org, cmetcalf@tilera.com, Greg Kroah-Hartman , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , jic23@kernel.org List-Id: linux-input@vger.kernel.org On 07/22/2014 06:32 PM, Arnd Bergmann wrote: > On Sunday 20 July 2014 17:45:40 Chen Gang wrote: >>> >>> Next, I shall: >>> >>> - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly. >>> >>> - Try to make dummy IOMEM functions for score architecture. >>> >>> - Continue discussing with UML for it. >>> >> >> Oh, sorry, I forgot, after remove IOMEM from kernel, also s390 and tile >> need implement dummy IOMEM if !PCI. >> >> If possible, I shall try to implement the dummy IOMEM in 'asm-generic', >> and let uml, score, s390 and tile use them when they need. > > Sorry for going round in circles, but looking back at the original patches, > adding the extra 'depends on HAS_IOMEM' does seem much better than the > other suggestions that came afterwards. > > In particular, removing HAS_IOMEM and NO_IOMEM sounds like an awful idea > to me. I'd rather add a HAS_IOPORT in addition to also catch architectures > that have no support for PC-style PIO. > Welcome any other members (especially driver members) ideas and suggestions -- driver members and architecture members have different tastes and different roles. For me, if no additional reply, I prefer to keep current status, and still add 'depends on HAS_IOMEM' for each driver which need it, but I am not sure whether driver members can bear it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed