From: "Andreas Färber" <afaerber@suse.de>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Lee Jones <lee.jones@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Simon Glass <sjg@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Derek Basehore <dbasehore@chromium.org>,
Todd Broch <tbroch@chromium.org>, Olof Johansson <olof@lixom.net>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm.
Date: Tue, 29 Jul 2014 15:08:16 +0200 [thread overview]
Message-ID: <53D79CC0.9050508@suse.de> (raw)
In-Reply-To: <1406549967-21291-8-git-send-email-javier.martinez@collabora.co.uk>
Am 28.07.2014 14:19, schrieb Javier Martinez Canillas:
> From: Todd Broch <tbroch@chromium.org>
>
> Previous algorithm was a bit conservative and complicating with
> respect to identifying key ghosting. This CL uses the bitops hamming
> weight function (hweight8) to count the number of matching rows for
> colM & colN. If that number is > 1 ghosting is present.
>
> Additionally it removes NULL keys and our one virtual keypress
> KEY_BATTERY from consideration as these inputs are never physical
> keypresses.
>
> Signed-off-by: Todd Broch <tbroch@chromium.org>
> Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
> Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
This seems to fix my Ctrl+O problems on Spring reported a while ago,
Tested-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2014-07-29 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 12:19 [PATCH 0/7] Second batch of cleanups for cros_ec Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3 Javier Martinez Canillas
[not found] ` <1406549967-21291-3-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-08-01 17:59 ` Wolfram Sang
2014-08-01 18:05 ` Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 3/7] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 5/7] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Javier Martinez Canillas
[not found] ` <1406549967-21291-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-07-28 12:19 ` [PATCH 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 6/7] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas
2014-07-29 12:34 ` Andreas Färber
2014-07-29 13:28 ` Javier Martinez Canillas
2014-07-29 12:27 ` [PATCH 0/7] Second batch of cleanups for cros_ec Andreas Färber
[not found] ` <53D79328.8060609-l3A5Bk7waGM@public.gmane.org>
2014-07-29 12:58 ` Javier Martinez Canillas
2014-07-28 12:19 ` [PATCH 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm Javier Martinez Canillas
2014-07-29 13:08 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D79CC0.9050508@suse.de \
--to=afaerber@suse.de \
--cc=abrestic@chromium.org \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@chromium.org \
--cc=tbroch@chromium.org \
--cc=wfrichar@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).