From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [RESEND PATCH 4/7] mfd: cros_ec: move locking into cros_ec_cmd_xfer Date: Thu, 21 Aug 2014 12:24:53 +0200 Message-ID: <53F5C8F5.9030100@collabora.co.uk> References: <1408536812-7836-1-git-send-email-javier.martinez@collabora.co.uk> <1408536812-7836-5-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:43758 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbaHUKZB (ORCPT ); Thu, 21 Aug 2014 06:25:01 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Doug Anderson Cc: Lee Jones , Wolfram Sang , Dmitry Torokhov , Simon Glass , Bill Richardson , Andrew Bresticker , Derek Basehore , Todd Broch , Olof Johansson , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "linux-i2c@vger.kernel.org" , "linux-input@vger.kernel.org" , linux-samsung-soc Hello Doug, On 08/21/2014 12:36 AM, Doug Anderson wrote: > Javier, > > On Wed, Aug 20, 2014 at 5:13 AM, Javier Martinez Canillas > wrote: >> From: Andrew Bresticker >> >> Now that there's a central cros_ec_cmd_xfer(), move the locking >> out of the SPI and LPC drivers. > > Slight nit that the LPC driver doesn't exist upstream. This is in > prep for adding the LPC driver, though. > Right, the downstream commit was also touching the LPC driver and I stripped that part but forget to update the commit message, sorry about that. I'll fix it and do a re-spin. > >> Signed-off-by: Andrew Bresticker >> Reviewed-by: Simon Glass >> Signed-off-by: Javier Martinez Canillas >> --- >> drivers/mfd/cros_ec.c | 10 +++++++++- >> drivers/mfd/cros_ec_spi.c | 11 ----------- >> 2 files changed, 9 insertions(+), 12 deletions(-) > > After comment nitfix: > > Reviewed-by: Doug Anderson > Thanks and best regards, Javier