From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description Date: Thu, 21 Aug 2014 22:28:56 +0400 Message-ID: <53F63A68.1080002@cogentembedded.com> References: <1408645143-25690-1-git-send-email-dmurphy@ti.com> <1408645143-25690-2-git-send-email-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408645143-25690-2-git-send-email-dmurphy@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Dan Murphy , linux-input@vger.kernel.org, dmitry.torokhov@gmail.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org Hello. On 08/21/2014 10:19 PM, Dan Murphy wrote: > DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. > Adding dt binding for this part > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt > new file mode 100644 > index 0000000..525216d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt > @@ -0,0 +1,18 @@ > +Texas Instruments - drv2667 Haptics driver > + > +The drv2667 uses serial control bus communicates through I2C protocols I can't parse that. > + > +Required properties: > + - compatible - "ti,drv2667" - DRV2667 > + - reg - I2C slave address > + - vbat-supply - Required supply regulator > + > +Example: > + > +drv2667: drv2667@59 { > + compatible = "ti,drv2667"; > + reg = <0x59>; You say "vbat-supply" is mandatory, yet you don't have it in your example? WBR, Sergei