From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Dan Murphy <dmurphy@ti.com>,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description
Date: Thu, 21 Aug 2014 23:04:15 +0400 [thread overview]
Message-ID: <53F642AF.3070200@cogentembedded.com> (raw)
In-Reply-To: <1408645143-25690-2-git-send-email-dmurphy@ti.com>
Hello.
On 08/21/2014 10:19 PM, Dan Murphy wrote:
> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators.
> Adding dt binding for this part
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt
> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt
> new file mode 100644
> index 0000000..525216d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt
> @@ -0,0 +1,18 @@
> +Texas Instruments - drv2667 Haptics driver
> +
> +The drv2667 uses serial control bus communicates through I2C protocols
> +
> +Required properties:
> + - compatible - "ti,drv2667" - DRV2667
> + - reg - I2C slave address
> + - vbat-supply - Required supply regulator
> +
> +Example:
> +
> +drv2667: drv2667@59 {
The ePAPR standard [1] has something to say on this matter:
"The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model."
> + compatible = "ti,drv2667";
Indented too much to the right.
> + reg = <0x59>;
Still no "vbat-supply"... :-/
> +};
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-08-21 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 18:19 input: drv2667: add support for drv2667 haptic driver Dan Murphy
2014-08-21 18:19 ` [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description Dan Murphy
2014-08-21 18:28 ` Sergei Shtylyov
2014-08-21 18:30 ` Murphy, Dan
2014-08-21 19:04 ` Sergei Shtylyov [this message]
2014-08-21 19:14 ` Murphy, Dan
2014-08-21 19:32 ` Sergei Shtylyov
2014-08-21 18:19 ` [PATCH 2/2] input: misc: Add support for the DRV2667 haptic driver Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F642AF.3070200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).