* [PATCH] Input: cap1106 - fix register definition
@ 2014-09-02 6:32 Klaus Goger
2014-09-02 7:43 ` Daniel Mack
0 siblings, 1 reply; 4+ messages in thread
From: Klaus Goger @ 2014-09-02 6:32 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Daniel Mack, linux-input, linux-kernel, Klaus Goger
Use the correct register address for Calibration Active and Interrupt
Enable
Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
---
drivers/input/keyboard/cap1106.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c
index 180b184..d70b65a 100644
--- a/drivers/input/keyboard/cap1106.c
+++ b/drivers/input/keyboard/cap1106.c
@@ -33,8 +33,8 @@
#define CAP1106_REG_SENSOR_CONFIG 0x22
#define CAP1106_REG_SENSOR_CONFIG2 0x23
#define CAP1106_REG_SAMPLING_CONFIG 0x24
-#define CAP1106_REG_CALIBRATION 0x25
-#define CAP1106_REG_INT_ENABLE 0x26
+#define CAP1106_REG_CALIBRATION 0x26
+#define CAP1106_REG_INT_ENABLE 0x27
#define CAP1106_REG_REPEAT_RATE 0x28
#define CAP1106_REG_MT_CONFIG 0x2a
#define CAP1106_REG_MT_PATTERN_CONFIG 0x2b
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap1106 - fix register definition
2014-09-02 6:32 [PATCH] Input: cap1106 - fix register definition Klaus Goger
@ 2014-09-02 7:43 ` Daniel Mack
2014-09-02 11:01 ` Klaus Goger
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2014-09-02 7:43 UTC (permalink / raw)
To: Klaus Goger, Dmitry Torokhov; +Cc: linux-input, linux-kernel
On 09/02/2014 08:32 AM, Klaus Goger wrote:
> Use the correct register address for Calibration Active and Interrupt
> Enable
>
> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
These register definitions are currently unused, but your fix is
correct. Just curious - are you planning to send patches that make use
of them?
Acked-by: Daniel Mack <zonque@gmail.com>
Thanks,
Daniel
> ---
> drivers/input/keyboard/cap1106.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c
> index 180b184..d70b65a 100644
> --- a/drivers/input/keyboard/cap1106.c
> +++ b/drivers/input/keyboard/cap1106.c
> @@ -33,8 +33,8 @@
> #define CAP1106_REG_SENSOR_CONFIG 0x22
> #define CAP1106_REG_SENSOR_CONFIG2 0x23
> #define CAP1106_REG_SAMPLING_CONFIG 0x24
> -#define CAP1106_REG_CALIBRATION 0x25
> -#define CAP1106_REG_INT_ENABLE 0x26
> +#define CAP1106_REG_CALIBRATION 0x26
> +#define CAP1106_REG_INT_ENABLE 0x27
> #define CAP1106_REG_REPEAT_RATE 0x28
> #define CAP1106_REG_MT_CONFIG 0x2a
> #define CAP1106_REG_MT_PATTERN_CONFIG 0x2b
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap1106 - fix register definition
2014-09-02 7:43 ` Daniel Mack
@ 2014-09-02 11:01 ` Klaus Goger
2014-09-08 21:46 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Klaus Goger @ 2014-09-02 11:01 UTC (permalink / raw)
To: Daniel Mack; +Cc: Dmitry Torokhov, linux-input, linux-kernel
On Sep 2, 2014, at 9:43 AM, Daniel Mack <zonque@gmail.com> wrote:
> On 09/02/2014 08:32 AM, Klaus Goger wrote:
>> Use the correct register address for Calibration Active and Interrupt
>> Enable
>>
>> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
>
> These register definitions are currently unused, but your fix is
> correct. Just curious - are you planning to send patches that make use
> of them?
I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to
decide how to expose it to the user. Probably adding another device tree
option. But somehow it feels like cluttering up the dts.
Once I have settled about that I will send patches.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap1106 - fix register definition
2014-09-02 11:01 ` Klaus Goger
@ 2014-09-08 21:46 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2014-09-08 21:46 UTC (permalink / raw)
To: Klaus Goger; +Cc: Daniel Mack, linux-input, linux-kernel
On Tue, Sep 02, 2014 at 01:01:11PM +0200, Klaus Goger wrote:
> On Sep 2, 2014, at 9:43 AM, Daniel Mack <zonque@gmail.com> wrote:
> > On 09/02/2014 08:32 AM, Klaus Goger wrote:
> >> Use the correct register address for Calibration Active and Interrupt
> >> Enable
> >>
> >> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
> >
> > These register definitions are currently unused, but your fix is
> > correct. Just curious - are you planning to send patches that make use
> > of them?
>
> I want to use CAP1106_REG_SENSITIVITY_CONTROL but I have yet to
> decide how to expose it to the user. Probably adding another device tree
> option. But somehow it feels like cluttering up the dts.
> Once I have settled about that I will send patches.
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-08 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 6:32 [PATCH] Input: cap1106 - fix register definition Klaus Goger
2014-09-02 7:43 ` Daniel Mack
2014-09-02 11:01 ` Klaus Goger
2014-09-08 21:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).