From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Lee Jones <lee.jones@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, "Bowens,
Alan" <Alan.Bowens@atmel.com>, Benson Leung <bleung@chromium.org>,
yufeng Shen <miletus@google.com>
Subject: Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table
Date: Thu, 11 Sep 2014 13:24:34 +0100 [thread overview]
Message-ID: <54119482.6070506@itdev.co.uk> (raw)
In-Reply-To: <54118A7E.4090902@collabora.co.uk>
On 11/09/14 12:41, Javier Martinez Canillas wrote:
> On 09/11/2014 01:35 PM, Wolfram Sang wrote:
>>>> This is a workaround. It would make sense, however, to add it because we
>>>> want to support i2c_board_info structures.
>>>>
>>>
>>> I think it really depends if an IP block can be used on non-DT platforms
>>> (which I think is true for this trackpad) but if a driver is for an IP block
>>> that can only be used on a DT-only platform (e.g: a PMIC that is controlled
>>> over I2C and is only compatible with a DT-only SoC) then I don't think we need
>>> to support the i2c_board_info structure and can get rid of the I2C ID table on
>>> these drivers once Lee series land.
>>
>> That is exactly what I meant. It should be only added if there is a
>> reason other than "workaround". If you say, it doesn't make sense on
>> non-DT, then it should not be added.
>
> Sorry for explaining myself badly. I just tried to say that this is a decision
> that has to be made on a per-driver basis but I don't really know if makes
> sense or not in this case since I don't know if this device is (or could be)
> shipped on non-DT platforms. Nick is in a much better position to answer that
> question.
There are plenty of out-of-tree users of this driver which don't use DT.
The most significant use I'm aware of is on Chromium OS systems.
next prev parent reply other threads:[~2014-09-11 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 7:52 [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table Sjoerd Simons
2014-09-09 10:21 ` Javier Martinez Canillas
2014-09-09 10:29 ` Nick Dyer
2014-09-09 10:54 ` Sjoerd Simons
2014-09-10 9:28 ` Lee Jones
2014-09-11 8:00 ` Sjoerd Simons
2014-09-11 8:38 ` Javier Martinez Canillas
2014-09-11 9:19 ` Nick Dyer
2014-09-11 9:54 ` Javier Martinez Canillas
2014-09-11 11:08 ` Wolfram Sang
2014-09-11 11:24 ` Javier Martinez Canillas
2014-09-11 11:35 ` Wolfram Sang
2014-09-11 11:41 ` Javier Martinez Canillas
2014-09-11 12:24 ` Nick Dyer [this message]
2014-09-09 12:36 ` Nick Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54119482.6070506@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=Alan.Bowens@atmel.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=miletus@google.com \
--cc=sjoerd.simons@collabora.co.uk \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).