From: Daniel Mack <daniel@zonque.org>
To: Matt Ranostay <mranostay@gmail.com>,
galak@codeaurora.org, dmitry.torokhov@gmail.com,
zonque@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support
Date: Sat, 27 Sep 2014 20:21:38 +0200 [thread overview]
Message-ID: <54270032.5010204@zonque.org> (raw)
In-Reply-To: <1411622662-16581-2-git-send-email-mranostay@gmail.com>
On 09/25/2014 07:24 AM, Matt Ranostay wrote:
> cap1106 driver can support much more one device make the driver
> generic for support of similiar parts.
>
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
> ---
> .../devicetree/bindings/input/cap1106.txt | 53 ----
> .../devicetree/bindings/input/cap11xx.txt | 54 ++++
> drivers/input/keyboard/Kconfig | 8 +-
> drivers/input/keyboard/Makefile | 2 +-
> drivers/input/keyboard/cap1106.c | 341 ---------------------
> drivers/input/keyboard/cap11xx.c | 340 ++++++++++++++++++++
> 6 files changed, 399 insertions(+), 399 deletions(-)
As I've said, such a patch is really a whole lot more readable if you
use the -M switch for git format-patch to detect renames.
Other than that, the series now looks good to me. I can't test it,
however, as I don't have access to the hardware anymore.
Reviewed-by: Daniel Mack <daniel@zonque.org>
Thanks,
Daniel
next prev parent reply other threads:[~2014-09-27 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 5:24 [PATCH v3 0/3] cap1106: add support for cap11xx variants Matt Ranostay
2014-09-25 5:24 ` [PATCH v3 1/3] cap11xx: make driver generic for variant support Matt Ranostay
2014-09-27 18:21 ` Daniel Mack [this message]
2014-09-29 2:45 ` Matt Ranostay
2014-09-25 5:24 ` [PATCH v3 2/3] cap11xx: Add support for various cap11xx devices Matt Ranostay
2014-09-25 5:24 ` [PATCH v3 3/3] cap11xx: support for irq-active-high option Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54270032.5010204@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).