* [PATCH] i8042: Add noloop quirk for Asus X750LN
@ 2014-10-11 13:09 Hans de Goede
2014-10-11 18:35 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2014-10-11 13:09 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Hans de Goede
Without this the aux port does not get detected, and consequently the touchpad
will not work.
https://bugzilla.redhat.com/show_bug.cgi?id=1110011
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/serio/i8042-x86ia64io.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 40b7d6c..4a6d05d 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -101,6 +101,12 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
},
{
.matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X750LN"),
+ },
+ },
+ {
+ .matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Compaq"),
DMI_MATCH(DMI_PRODUCT_NAME , "ProLiant"),
DMI_MATCH(DMI_PRODUCT_VERSION, "8500"),
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i8042: Add noloop quirk for Asus X750LN
2014-10-11 13:09 [PATCH] i8042: Add noloop quirk for Asus X750LN Hans de Goede
@ 2014-10-11 18:35 ` Dmitry Torokhov
2014-10-30 18:34 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2014-10-11 18:35 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote:
> Without this the aux port does not get detected, and consequently the touchpad
> will not work.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1110011
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
> ---
> drivers/input/serio/i8042-x86ia64io.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 40b7d6c..4a6d05d 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -101,6 +101,12 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
> },
> {
> .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X750LN"),
> + },
> + },
> + {
> + .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Compaq"),
> DMI_MATCH(DMI_PRODUCT_NAME , "ProLiant"),
> DMI_MATCH(DMI_PRODUCT_VERSION, "8500"),
> --
> 2.1.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i8042: Add noloop quirk for Asus X750LN
2014-10-11 18:35 ` Dmitry Torokhov
@ 2014-10-30 18:34 ` Dmitry Torokhov
2014-10-31 8:21 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2014-10-30 18:34 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote:
> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote:
> > Without this the aux port does not get detected, and consequently the touchpad
> > will not work.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1110011
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Applied, thank you.
Hans,
Do you still have dmidecode for this laptop around? Can I see it? I am
just wondering what part of AUX_LOOP was causing issues. Was it aux
delivery test or loop test itself?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i8042: Add noloop quirk for Asus X750LN
2014-10-30 18:34 ` Dmitry Torokhov
@ 2014-10-31 8:21 ` Hans de Goede
2014-10-31 8:23 ` Hans de Goede
2014-10-31 16:46 ` Dmitry Torokhov
0 siblings, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2014-10-31 8:21 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Hi,
On 10/30/2014 07:34 PM, Dmitry Torokhov wrote:
> On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote:
>> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote:
>>> Without this the aux port does not get detected, and consequently the touchpad
>>> will not work.
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1110011
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Applied, thank you.
>
> Hans,
>
> Do you still have dmidecode for this laptop around?
No I took the necessary identification strings from the dmesg, which is here:
https://bugzilla.redhat.com/attachment.cgi?id=944389
I'll drop you a private mail with the users email address, then you
can get into contact with him directly, I expect him to be willing to
help debug this further.
> Can I see it? I am
> just wondering what part of AUX_LOOP was causing issues. Was it aux
> delivery test or loop test itself?
I was wondering myself, which is why the above dmesg is with:
"dyndbg=file drivers/input/serio/* +p"
But that does not seem to print anything extra ..., is the i8042 code
properly using one of the foo_dbg macro's ?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i8042: Add noloop quirk for Asus X750LN
2014-10-31 8:21 ` Hans de Goede
@ 2014-10-31 8:23 ` Hans de Goede
2014-10-31 16:46 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-10-31 8:23 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Hi,
On 10/31/2014 09:21 AM, Hans de Goede wrote:
> Hi,
>
> On 10/30/2014 07:34 PM, Dmitry Torokhov wrote:
>> On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote:
>>> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote:
>>>> Without this the aux port does not get detected, and consequently the touchpad
>>>> will not work.
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1110011
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> Applied, thank you.
>>
>> Hans,
>>
>> Do you still have dmidecode for this laptop around?
>
> No I took the necessary identification strings from the dmesg, which is here:
>
> https://bugzilla.redhat.com/attachment.cgi?id=944389
>
> I'll drop you a private mail with the users email address, then you
> can get into contact with him directly, I expect him to be willing to
> help debug this further.
>
>> Can I see it? I am
>> just wondering what part of AUX_LOOP was causing issues. Was it aux
>> delivery test or loop test itself?
>
> I was wondering myself, which is why the above dmesg is with:
>
> "dyndbg=file drivers/input/serio/* +p"
>
> But that does not seem to print anything extra ..., is the i8042 code
> properly using one of the foo_dbg macro's ?
Ah, wait I just realized that even though the user was asking for help
in Red Hat bugzilla he is actually a ubuntu user, I guess their kernels
just don't have dyndbg turned on.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i8042: Add noloop quirk for Asus X750LN
2014-10-31 8:21 ` Hans de Goede
2014-10-31 8:23 ` Hans de Goede
@ 2014-10-31 16:46 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2014-10-31 16:46 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Fri, Oct 31, 2014 at 09:21:53AM +0100, Hans de Goede wrote:
> Hi,
>
> On 10/30/2014 07:34 PM, Dmitry Torokhov wrote:
> > On Sat, Oct 11, 2014 at 11:35:23AM -0700, Dmitry Torokhov wrote:
> >> On Sat, Oct 11, 2014 at 03:09:06PM +0200, Hans de Goede wrote:
> >>> Without this the aux port does not get detected, and consequently the touchpad
> >>> will not work.
> >>>
> >>> https://bugzilla.redhat.com/show_bug.cgi?id=1110011
> >>>
> >>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>
> >> Applied, thank you.
> >
> > Hans,
> >
> > Do you still have dmidecode for this laptop around?
>
> No I took the necessary identification strings from the dmesg, which is here:
>
> https://bugzilla.redhat.com/attachment.cgi?id=944389
>
> I'll drop you a private mail with the users email address, then you
> can get into contact with him directly, I expect him to be willing to
> help debug this further.
Thanks!
>
> > Can I see it? I am
> > just wondering what part of AUX_LOOP was causing issues. Was it aux
> > delivery test or loop test itself?
>
> I was wondering myself, which is why the above dmesg is with:
>
> "dyndbg=file drivers/input/serio/* +p"
>
> But that does not seem to print anything extra ..., is the i8042 code
> properly using one of the foo_dbg macro's ?
>
The debug facilities in i8042 were done way before dynamic debug so if
you want to see the data stream you need i8042.debug. That works on all
kernels regardless of config.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-31 16:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-11 13:09 [PATCH] i8042: Add noloop quirk for Asus X750LN Hans de Goede
2014-10-11 18:35 ` Dmitry Torokhov
2014-10-30 18:34 ` Dmitry Torokhov
2014-10-31 8:21 ` Hans de Goede
2014-10-31 8:23 ` Hans de Goede
2014-10-31 16:46 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).