From: Hector Martin <hector@marcansoft.com>
To: Frank Praznik <frank.praznik@oh.rr.com>, linux-input@vger.kernel.org
Cc: jkosina@suse.cz, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] hid: sony: Use kernel allocated buffers for HID reports
Date: Wed, 12 Nov 2014 03:20:57 +0900 [thread overview]
Message-ID: <54625389.4040900@marcansoft.com> (raw)
In-Reply-To: <1415728913-2679-1-git-send-email-frank.praznik@oh.rr.com>
On 12/11/14 03:01, Frank Praznik wrote:
> Replace stack buffers with kernel allocated buffers when sending
> and receiving HID reports to prevent issues with DMA transfers
> on certain hardware.
>
> Output report buffers are allocated at initialization time to avoid
> excessive kmalloc and kfree calls.
>
> Signed-off-by: Frank Praznik <frank.praznik@oh.rr.com>
> ---
>
> I'm CC-ing the original bug reporter to see if he can test this patch
> on whatever platform was giving him trouble as I can't replicate the
> reported error on my end.
Seems to work fine with the patch. Thanks!
FWIW, this is 3.17.1-hardened (I wonder if the grsecurity patches have
anything to do with it... maybe they do something to the stack) on an
Intel 7 Series (Panther Point) PCH's EHCI controller (with a couple of
hubs along the way).
--
Hector Martin (hector@marcansoft.com)
Public Key: http://www.marcansoft.com/marcan.asc
next prev parent reply other threads:[~2014-11-11 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:01 [PATCH] hid: sony: Use kernel allocated buffers for HID reports Frank Praznik
2014-11-11 18:20 ` Hector Martin [this message]
2014-11-11 19:04 ` Dmitry Torokhov
2014-11-12 15:18 ` Frank Praznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54625389.4040900@marcansoft.com \
--to=hector@marcansoft.com \
--cc=dmitry.torokhov@gmail.com \
--cc=frank.praznik@oh.rr.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).