From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?P=E9ter?= Ujfalusi Subject: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator Date: Thu, 16 Jun 2011 14:13:59 +0300 Message-ID: <5476342.2jZLF0UGcI@barack> References: <1307706876-4768-1-git-send-email-peter.ujfalusi@ti.com> <20110615081858.GM8141@htj.dyndns.org> <20110615082301.GN8141@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20110615082301.GN8141@htj.dyndns.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tejun Heo Cc: "alsa-devel@alsa-project.org" , Mark Brown , Samuel Ortiz , Tony Lindgren , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "Lopez Cruz, Misael" , "linux-omap@vger.kernel.org" , "Girdwood, Liam" List-Id: linux-input@vger.kernel.org On Wednesday 15 June 2011 10:23:01 Tejun Heo wrote: > On Wed, Jun 15, 2011 at 10:18:58AM +0200, Tejun Heo wrote: > > No human being can feel 120usec difference and I can't see how using > > HIGHPRI is justified here (which is what the code is doing > > _accidentally_ by using singlethread_workqueue). > = > Ooh, one more thing, and even if you insist on using HIGHPRI (please > don't), you don't need to create workqueue for each device. You can > just create one for the whole driver in init and destroy it from exit. > What matters is the HIGHPRI attribute of the workqueue. The number of > workqueues is completely irrelevant. Fair enough. I'll move to create_workqueue. If we later find issues with this (in a 'live' system), we can figure out a = way to fix it. Thank you for your time on this. I'll make the changes accordingly. Regards, P=E9ter