From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-input@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch
Date: Wed, 17 Dec 2014 10:06:52 +0000 [thread overview]
Message-ID: <549155BC.4080803@itdev.co.uk> (raw)
In-Reply-To: <54906FEB.7060702@collabora.co.uk>
On 16/12/14 17:46, Javier Martinez Canillas wrote:
> On 12/16/2014 06:07 PM, Nick Dyer wrote:
>> I had been keeping them separate on the basis that we don't want changes to
>> support new T100 features to cause regressions in the old T9 handling. But
>> there is a fair amount of duplication as you say, probably worth addressing.
>
> Yeah but if there are regressions I think we should address those instead of
> duplicating code, to make the driver more maintainable in the long term.
True enough. We will have to be careful to test on both types of device.
next prev parent reply other threads:[~2014-12-17 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 10:39 [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch Javier Martinez Canillas
2014-12-15 10:39 ` [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object Javier Martinez Canillas
2014-12-15 10:39 ` [PATCH 2/2] Input: atmel_mxt_ts - Split out touchpad initialisation logic Javier Martinez Canillas
2014-12-16 16:16 ` [PATCH 0/2] Input: atmel_mxt_ts - Add support for T100 multi-touch Nick Dyer
2014-12-16 16:34 ` Javier Martinez Canillas
2014-12-16 16:39 ` Nick Dyer
2014-12-16 16:49 ` Javier Martinez Canillas
2014-12-16 17:07 ` Nick Dyer
2014-12-16 17:46 ` Javier Martinez Canillas
2014-12-17 10:06 ` Nick Dyer [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-17 14:00 Javier Martinez Canillas
2015-03-27 20:29 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549155BC.4080803@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=olof@lixom.net \
--cc=rydberg@euromail.se \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).