linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Florian Echtler <floe@butterbrot.org>,
	linux-input <linux-input@vger.kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [RFC] [Patch] implement video driver for sur40
Date: Thu, 18 Dec 2014 15:11:29 +0100	[thread overview]
Message-ID: <5492E091.1060404@xs4all.nl> (raw)
In-Reply-To: <5492D7E8.504@butterbrot.org>

On 12/18/14 14:34, Florian Echtler wrote:
> Hello everyone,
> 
> as promised, I've finally implemented the missing raw video feature for
> the SUR40 touchscreen. Since this is a bit of a weird hybrid device
> (multitouch input as well as video), I'm hoping for comments from both
> communities (linux-input and linux-media). I'm also attaching the full
> source code for the moment (not yet a proper patch submission) so it's
> perhaps easier to get a view of the whole thing.
> 
> There's definitely some obvious cleanup still to be done (e.g. endpoint
> selection), but I'd like to ask for feedback early so I can get most
> issues fixed before really submitting a patch.
> 
> Thanks & best regards, Florian
> 

One thing you should do is to run the v4l2-compliance utility. Available
here: http://git.linuxtv.org/cgit.cgi/v4l-utils.git/

Compile from the git repo to ensure you have the latest version.

Run as 'v4l2-compliance -s' (-s starts streaming tests as well and it
assumes you have a valid input signal).

The driver shouldn't give any failures. When you post the actual patch,
then make sure you also paste in the output of 'v4l2-compliance -s' as
I'd like to see what it says.

Mail if you have any questions about the v4l2-compliance output. The failure
messages expect you to look at the v4l2-compliance source code as well,
but even than it is not always clear what is going on.

Regards,

	Hans

  reply	other threads:[~2014-12-18 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 13:34 [RFC] [Patch] implement video driver for sur40 Florian Echtler
2014-12-18 14:11 ` Hans Verkuil [this message]
2014-12-19 14:30   ` Florian Echtler
2014-12-19 14:36     ` Hans Verkuil
2014-12-19 14:57       ` Florian Echtler
2014-12-19 15:27         ` Hans Verkuil
2015-01-06  9:29           ` Florian Echtler
2015-01-06  9:36             ` Hans Verkuil
2015-01-06 10:17               ` Florian Echtler
2015-01-06 10:23                 ` Hans Verkuil
2015-01-06 12:09                   ` Florian Echtler
2015-01-06 13:01                     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5492E091.1060404@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=floe@butterbrot.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).