linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolai Kondrashov <spbnick@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input <linux-input@vger.kernel.org>
Subject: Merging hid-huion into hid-uclogic
Date: Sun, 25 Jan 2015 15:22:32 +0200	[thread overview]
Message-ID: <54C4EE18.4030005@gmail.com> (raw)

Hi Jiri, everyone,

I'd like to have your opinion if it will be fine to merge hid-huion.c into
hid-uclogic.c, keeping tablet support intact, of course.

The reason is, Huion tablets actually use UC-Logic hardware and the probing
method used in hid-huion.c huion_tablet_enable actually works with (at least)
newer UC-Logic tablets, including at least 6 Yiynova tablet models, a newer
version of Monoprice MP1060-HA60, and some Ugee models - all of them using
UC-Logic VID.

I have all of these working in various branches of digimend-kernel-drivers [1]
and waiting to be contributed, but putting them in hid-huion.c would make it
support more UC-Logic tablet models than hid-uclogic.c does (even though they
reuse their PIDs). And that might be awkward and confusing.

So, would it be a good idea to merge hid-huion.c into hid-uclogic.c and would
you accept such change into the kernel?

Thank you.

[1] https://github.com/DIGImend/digimend-kernel-drivers

             reply	other threads:[~2015-01-25 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 13:22 Nikolai Kondrashov [this message]
2015-01-27 10:10 ` Merging hid-huion into hid-uclogic Jiri Kosina
2015-01-27 11:10   ` Nikolai Kondrashov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C4EE18.4030005@gmail.com \
    --to=spbnick@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).