From: Hans de Goede <hdegoede@redhat.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Vadim Klishko <vadim@cirque.com>
Subject: Re: Dell ALPS patches for Dell Latitude 7250 & 7450
Date: Sun, 15 Feb 2015 17:40:48 +0100 [thread overview]
Message-ID: <54E0CC10.2000401@redhat.com> (raw)
In-Reply-To: <201502151738.36559@pali>
Hi,
On 15-02-15 17:38, Pali Rohár wrote:
> On Wednesday 11 February 2015 08:38:58 Hans de Goede wrote:
>> Thanks for this and the other related mail. I also have an
>> alps.c directly from alps themselves which adds support for
>> v8 and v9 protocols. The problem is that like with v7 the
>> code is not really in a state where we want to take it as is,
>> e.g. it does clickpad softbutton emulation in the kernel
>> instead of leaving it to userspace.
>>
>> I spend a considerable amount of time cleaning up the alps
>> code itself and then adding a cleaner version of the v7 code,
>> we should do the same for the v8 and v9 code probably but
>> that requires someone with hardware access so that we can
>> actually test the end result.
>>
>> Regards,
>>
>> Hans
>
> Ok. Hans, can you look at least on second one patch?
> http://www.spinics.net/lists/linux-input/msg36554.html
>
> This is a bit shorter patch and maybe easier to review and decide
> if is needed or not...
I think you no that particular bit of the code better then me know,
given the recent fixes you've been doing there. I think it is best
to not take that patch / hack until we actually have reports from
someone with a machine where such a fix is needed.
Regards,
Hans
prev parent reply other threads:[~2015-02-15 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 13:19 Dell ALPS patches for Dell Latitude 7250 & 7450 Pali Rohár
2015-02-11 7:38 ` Hans de Goede
2015-02-15 16:38 ` Pali Rohár
2015-02-15 16:40 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E0CC10.2000401@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=vadim@cirque.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).