From: Nikolai Kondrashov <spbnick@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
DIGImend-devel <DIGImend-devel@lists.sourceforge.net>
Subject: Re: [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool
Date: Sun, 01 Mar 2015 20:04:39 +0200 [thread overview]
Message-ID: <54F354B7.9020402@gmail.com> (raw)
In-Reply-To: <1424977049-18648-4-git-send-email-benjamin.tissoires@redhat.com>
On 02/26/2015 08:57 PM, Benjamin Tissoires wrote:
> We append "Pen", "Pad", "Mouse", "Keyboard", "Consumer Control" or
> "System Control" suffix to the appropriate input node to match what
> the Wacom driver does and be more convenient for the user to know
> which one is which.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
I read the kernel code and tested this a little. This looks and works fine.
Reviewed-by: Nikolai Kondrashov <spbnick@gmail.com>
next prev parent reply other threads:[~2015-03-01 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 18:57 [PATCH v2 0/6] HID: huion/uclogic merge and few additions Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 1/6] HID: uclogic: Set quirks from inside the driver Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 2/6] HID: uclogic: merge hid-huion driver in hid-uclogic Benjamin Tissoires
2015-02-26 18:57 ` [PATCH v2 3/6] HID: uclogic: name the input nodes based on their tool Benjamin Tissoires
2015-03-01 18:04 ` Nikolai Kondrashov [this message]
2015-02-26 18:57 ` [PATCH v2 4/6] HID: uclogic: apply quirk NO_EMPTY_INPUT Benjamin Tissoires
2015-03-01 18:07 ` Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 5/6] HID: uclogic: discard the extra Pen input node on Huion tablets Benjamin Tissoires
2015-03-01 18:13 ` Nikolai Kondrashov
2015-02-26 18:57 ` [PATCH v2 6/6] HID: uclogic: actually invert the in-range bit for huion tablets only Benjamin Tissoires
2015-02-28 13:59 ` Nikolai Kondrashov
2015-03-02 22:25 ` Benjamin Tissoires
2015-03-03 10:54 ` Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F354B7.9020402@gmail.com \
--to=spbnick@gmail.com \
--cc=DIGImend-devel@lists.sourceforge.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).