From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 0/3] tty: eliminate 64 byte stack buffers passed to tty_name Date: Fri, 03 Apr 2015 20:20:41 -0400 Message-ID: <551F2E59.5080503@hurleysoftware.com> References: <1427810160-15779-1-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f173.google.com ([209.85.216.173]:33985 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbbDDAUu (ORCPT ); Fri, 3 Apr 2015 20:20:50 -0400 Received: by qcay5 with SMTP id y5so97979879qca.1 for ; Fri, 03 Apr 2015 17:20:49 -0700 (PDT) In-Reply-To: <1427810160-15779-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Rasmus Villemoes , Greg Kroah-Hartman Cc: Dmitry Torokhov , Jiri Slaby , Mikael Starvik , Jesper Nilsson , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com, linux-serial@vger.kernel.org On 03/31/2015 09:55 AM, Rasmus Villemoes wrote: > All users of tty_name pass the return value directly to a printf > function, so we might as well use tty->name directly instead of > copying it to a user-supplied (stack) buffer. Reviewed-by: Peter Hurley