From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 01/10] mfd/extcon: max77693: Remove unused extern declarations and max77693_dev members Date: Mon, 04 May 2015 15:54:30 +0900 Message-ID: <554717A6.40807@samsung.com> References: <1430305114-23598-1-git-send-email-k.kozlowski.k@gmail.com> <1430305114-23598-2-git-send-email-k.kozlowski.k@gmail.com> <5547156C.9030402@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:30477 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbbEDGyd (ORCPT ); Mon, 4 May 2015 02:54:33 -0400 In-reply-to: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dza2k=?= Cc: MyungJoo Ham , Dmitry Torokhov , Samuel Ortiz , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org On 05/04/2015 03:49 PM, Krzysztof Koz=C5=82owski wrote: > 2015-05-04 15:45 GMT+09:00 Chanwoo Choi : >> On 04/29/2015 07:58 PM, Krzysztof Kozlowski wrote: >>> Clean up the max77693 private header file by removing: >>> 1. Left-overs from previous way of interrupt handling (driver uses >>> regmap_irq_chip). >>> 2. Unused members of struct 'max77693_dev' related to interrupts in >>> extcon driver. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> drivers/extcon/extcon-max77693.c | 4 ---- >>> include/linux/mfd/max77693-private.h | 8 -------- >>> 2 files changed, 12 deletions(-) >>> >>> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extc= on-max77693.c >>> index a66bec8f6252..760e1e2cc1ce 100644 >>> --- a/drivers/extcon/extcon-max77693.c >>> +++ b/drivers/extcon/extcon-max77693.c >>> @@ -1218,10 +1218,6 @@ static int max77693_muic_probe(struct platfo= rm_device *pdev) >>> irq_src =3D MUIC_INT3; >>> break; >>> } >>> - >>> - if (irq_src < MAX77693_IRQ_GROUP_NR) >>> - info->max77693->irq_masks_cur[irq_src] >>> - =3D init_data[i].data; >>> } >> >> When removing the unused statement, I think you better to remove it = as following: >> because 'enum max77693_irq_source irq_src' is not used. >=20 > Yes, you're right. Actually some time ago I removed all of this: > extcon: max77693: Remove left-over code after switching to regmap irq= chip > http://lkml.iu.edu/hypermail/linux/kernel/1410.2/03403.html >=20 >> >> for (i =3D 0; i < num_init_data; i++) { >> - enum max77693_irq_source irq_src >> - =3D MAX77693_IRQ_GROUP_NR; >> - >> regmap_write(info->max77693->regmap_muic, >> init_data[i].addr, >> init_data[i].data); >> - >> - switch (init_data[i].addr) { >> - case MAX77693_MUIC_REG_INTMASK1: >> - irq_src =3D MUIC_INT1; >> - break; >> - case MAX77693_MUIC_REG_INTMASK2: >> - irq_src =3D MUIC_INT2; >> - break; >> - case MAX77693_MUIC_REG_INTMASK3: >> - irq_src =3D MUIC_INT3; >> - break; >> - } >> - >> - if (irq_src < MAX77693_IRQ_GROUP_NR) >> - info->max77693->irq_masks_cur[irq_src] >> - =3D init_data[i].data; >> } >> >> [snip] >> >> Except for upper comment, Looks good to me. >=20 > Okay, I'll do as you suggested and add your ack (in case it will go > through some other tree). I'm wondering the merge confilct if this patch will be merged on other = tree. Because extcon-max77693.c was already modified on extcon-next branch. So, If the base commit of this patch is different, there are potential = merge conflict. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html