From: Daniel Mack <daniel@zonque.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matt Ranostay <mranostay@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] cap11xx: add LED support
Date: Wed, 10 Jun 2015 00:40:24 +0200 [thread overview]
Message-ID: <55776B58.9080102@zonque.org> (raw)
In-Reply-To: <20150609171254.GF6338@dtor-ws>
On 06/09/2015 07:12 PM, Dmitry Torokhov wrote:
> On Tue, Jun 09, 2015 at 07:25:42AM +0200, Daniel Mack wrote:
>> Use the .brightness_set_sync callback, so you don't have to dance around
>> with the workers at all.
>
> Umm, how will it help? You still can't sleep in set_brightness().
> brightness_set_sync() just says that the driver guarantees that the LED
> state will be set (or error returned) when the function returns.
Hmm, right. I was mislead by this comment in include/linux/leds.h:
/*
* Set LED brightness level immediately - it can block the caller for
* the time required for accessing a LED device register.
*/
But I in fact don't see any wrapper logic that magically uses a worker
when called from interrupt context.
Thanks for the heads-up!
Daniel
next prev parent reply other threads:[~2015-06-09 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 3:46 [PATCH] cap11xx: add LED support Matt Ranostay
2015-06-09 5:25 ` Daniel Mack
2015-06-09 17:12 ` Dmitry Torokhov
2015-06-09 17:30 ` Matt Ranostay
2015-06-09 22:40 ` Daniel Mack [this message]
2015-06-09 5:26 ` Daniel Mack
2015-06-09 16:18 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55776B58.9080102@zonque.org \
--to=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox